diff mbox series

[1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family

Message ID 20220701042919.18180-2-nm@ti.com (mailing list archive)
State Changes Requested
Headers show
Series iio: adc: ti-adc128s052: Add support for adc102s021 and family | expand

Commit Message

Nishanth Menon July 1, 2022, 4:29 a.m. UTC
The adcxx4s communicates with a host processor via an SPI/Microwire Bus
interface. The device family responds with 12bit data, of which the LSB
bits are 0 for the lower resolution devices. I have been able to test
adc102s051, hence adding just the missing ones in that family.

Lets reuse the binding to support the family of devices with name
ADC<bb><c>S<sss>, where
* bb is the resolution in number of bits (8, 10, 12)
* c is the number of channels (1, 2, 4, 8)
* sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
  and 101 for 1 MSPS)

Complete datasheets are available at TI's website here:
  https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf

Handling of 8, 10 and 12 bits converters are the same, the
unavailable bits are 0 in LSB :)

Inspired-by: drivers/hwmon/adcxx.c

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Checkpatch does complain with Inspired-by: insisting it to be an email
address.. but I was really inspired by the hwmon driver.. Don't know
what else to say here.. we could probably drop it?

 .../devicetree/bindings/iio/adc/ti,adc128s052.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski July 1, 2022, 6:38 a.m. UTC | #1
On 01/07/2022 06:29, Nishanth Menon wrote:
> The adcxx4s communicates with a host processor via an SPI/Microwire Bus
> interface. The device family responds with 12bit data, of which the LSB
> bits are 0 for the lower resolution devices. I have been able to test
> adc102s051, hence adding just the missing ones in that family.
> 
> Lets reuse the binding to support the family of devices with name
> ADC<bb><c>S<sss>, where
> * bb is the resolution in number of bits (8, 10, 12)
> * c is the number of channels (1, 2, 4, 8)
> * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
>   and 101 for 1 MSPS)
> 
> Complete datasheets are available at TI's website here:
>   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
> 
> Handling of 8, 10 and 12 bits converters are the same, the
> unavailable bits are 0 in LSB :)
> 
> Inspired-by: drivers/hwmon/adcxx.c
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> 
> Checkpatch does complain with Inspired-by: insisting it to be an email
> address.. but I was really inspired by the hwmon driver.. Don't know
> what else to say here.. we could probably drop it?

Drop it or convert to just test.

When passing checkpatch:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski July 1, 2022, 8:27 a.m. UTC | #2
On 01/07/2022 08:38, Krzysztof Kozlowski wrote:
> On 01/07/2022 06:29, Nishanth Menon wrote:
>> The adcxx4s communicates with a host processor via an SPI/Microwire Bus
>> interface. The device family responds with 12bit data, of which the LSB
>> bits are 0 for the lower resolution devices. I have been able to test
>> adc102s051, hence adding just the missing ones in that family.
>>
>> Lets reuse the binding to support the family of devices with name
>> ADC<bb><c>S<sss>, where
>> * bb is the resolution in number of bits (8, 10, 12)
>> * c is the number of channels (1, 2, 4, 8)
>> * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
>>   and 101 for 1 MSPS)
>>
>> Complete datasheets are available at TI's website here:
>>   https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
>>
>> Handling of 8, 10 and 12 bits converters are the same, the
>> unavailable bits are 0 in LSB :)
>>
>> Inspired-by: drivers/hwmon/adcxx.c
>>
>> Signed-off-by: Nishanth Menon <nm@ti.com>
>> ---
>>
>> Checkpatch does complain with Inspired-by: insisting it to be an email
>> address.. but I was really inspired by the hwmon driver.. Don't know
>> what else to say here.. we could probably drop it?
> 
> Drop it or convert to just test.

This should be:

Drop it or convert to just text sentence.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
index d54a0183f024..85adf53c83c1 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,adc128s052.yaml
@@ -16,6 +16,12 @@  description: |
 properties:
   compatible:
     enum:
+      - ti,adc082s021
+      - ti,adc082s051
+      - ti,adc082s101
+      - ti,adc102s021
+      - ti,adc102s051
+      - ti,adc102s101
       - ti,adc122s021
       - ti,adc122s051
       - ti,adc122s101