| Message ID | 20220711134312.234268-2-tmaimon77@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | iio: adc: npcm: add Arbel NPCM8XX support | expand |
On Mon, 11 Jul 2022 16:43:10 +0300, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 ADC. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.example.dtb: adc@f000c000: compatible: 'oneOf' conditional failed, one must be fixed: ['nuvoton,npcm750-adc'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob, Thanks for your comment, it will be addressed next version. On Mon, 11 Jul 2022 at 20:55, Rob Herring <robh@kernel.org> wrote: > > On Mon, 11 Jul 2022 16:43:10 +0300, Tomer Maimon wrote: > > Add a compatible string for Nuvoton BMC NPCM845 ADC. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.example.dtb: adc@f000c000: compatible: 'oneOf' conditional failed, one must be fixed: > ['nuvoton,npcm750-adc'] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/ > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Best regards, Tomer
On 11/07/2022 15:43, Tomer Maimon wrote: > Add a compatible string for Nuvoton BMC NPCM845 ADC. > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > index 001cf263b7d5..c9e9c5bf5e5b 100644 > --- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > @@ -14,7 +14,10 @@ description: > > properties: > compatible: > - const: nuvoton,npcm750-adc > + oneOf: > + - items: This does not make sense. oneOf with one item. You also create now list breaking all existing users/ABI. You probably wanted an enum here. > + - const: nuvoton,npcm750-adc > + - const: nuvoton,npcm845-adc > > reg: > maxItems: 1 Best regards, Krzysztof
Hi Krzysztof, On Tue, 12 Jul 2022 at 11:15, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 11/07/2022 15:43, Tomer Maimon wrote: > > Add a compatible string for Nuvoton BMC NPCM845 ADC. > > > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > > --- > > .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > > index 001cf263b7d5..c9e9c5bf5e5b 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml > > @@ -14,7 +14,10 @@ description: > > > > properties: > > compatible: > > - const: nuvoton,npcm750-adc > > + oneOf: > > + - items: > > This does not make sense. oneOf with one item. You also create now list > breaking all existing users/ABI. > > You probably wanted an enum here. indeed, thanks for your comment. > > > + - const: nuvoton,npcm750-adc > > + - const: nuvoton,npcm845-adc > > > > reg: > > maxItems: 1 > > > Best regards, > Krzysztof Best regards, Tomer
diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml index 001cf263b7d5..c9e9c5bf5e5b 100644 --- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml @@ -14,7 +14,10 @@ description: properties: compatible: - const: nuvoton,npcm750-adc + oneOf: + - items: + - const: nuvoton,npcm750-adc + - const: nuvoton,npcm845-adc reg: maxItems: 1
Add a compatible string for Nuvoton BMC NPCM845 ADC. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)