Message ID | 20220809073648.167821-8-marcus.folkesson@gmail.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | Improve MCP3911 driver | expand |
On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson <marcus.folkesson@gmail.com> wrote: > > The Data Ready Output Pin is either hard wired to work as high > impedance or push-pull. Make it configurable. ... > + description: > + Data Ready Pin Inactive State Control > + true = The DR pin state is high-impedance when data are NOT ready > + false = The DR pin state is a logic high when data are NOT ready Wouldn't be better to move " when data are NOT ready" to the main description text: Data Ready Pin Inactive State Control when data are NOT ready In this case it unloads the list and moves focus from the part of "NOT ready" to the real part of what you pointed out here -- "high-impedance" or "high".
On Tue, Aug 09, 2022 at 11:57:19AM +0200, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 9:32 AM Marcus Folkesson > <marcus.folkesson@gmail.com> wrote: > > > > The Data Ready Output Pin is either hard wired to work as high > > impedance or push-pull. Make it configurable. > > ... > > > + description: > > + Data Ready Pin Inactive State Control > > + true = The DR pin state is high-impedance when data are NOT ready > > + false = The DR pin state is a logic high when data are NOT ready > > Wouldn't be better to move " when data are NOT ready" to the main > description text: > > Data Ready Pin Inactive State Control when data are NOT ready > > In this case it unloads the list and moves focus from the part of "NOT > ready" to the real part of what you pointed out here -- > "high-impedance" or "high". I think I will put it as Data Ready Pin Inactive State Control true = The DR pin state is high-impedance false = The DR pin state is logic high As "NOT ready" is redundant is it is a "Inactive state control". > > > -- > With Best Regards, > Andy Shevchenko
diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml index 95ab285f4eba..57a16380f864 100644 --- a/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml +++ b/Documentation/devicetree/bindings/iio/adc/microchip,mcp3911.yaml @@ -36,6 +36,13 @@ properties: description: IRQ line of the ADC maxItems: 1 + microchip,data-ready-hiz: + description: + Data Ready Pin Inactive State Control + true = The DR pin state is high-impedance when data are NOT ready + false = The DR pin state is a logic high when data are NOT ready + type: boolean + microchip,device-addr: description: Device address when multiple MCP3911 chips are present on the same SPI bus. $ref: /schemas/types.yaml#/definitions/uint32