| Message ID | 20220815091647.1523532-1-dzagorui@cisco.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: ltc2497: Fix reading conversion results | expand |
On Mon, 15 Aug 2022 09:16:47 +0000 Denys Zagorui <dzagorui@cisco.com> wrote: > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > After the result of the previous conversion is read the chip > automatically starts a new conversion and doesn't accept new i2c > transfers until this conversion is completed which makes the function > return failure. That's rather nasty. Could we add a cheeky sleep in the other path to ensure there is always time for the conversion to be done? Not ideal, but might ensure there isn't a known problem path without introducing much complexity. > > So add an early return iff the programming of the new address isn't > needed. Note this will not fix the problem in general, but all cases > that are currently used. Once this changes we get the failure back, but > this can be addressed when the need arises. > > Fixes: 69548b7c2c4f ("iio: adc: ltc2497: split protocol independent part in a separate module ") > Reported-by: Meng Li <Meng.Li@windriver.com> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Tested-by: Denys Zagorui <dzagorui@cisco.com> > --- > drivers/iio/adc/ltc2497.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c > index f7c786f37ceb..78b93c99cc47 100644 > --- a/drivers/iio/adc/ltc2497.c > +++ b/drivers/iio/adc/ltc2497.c > @@ -41,6 +41,19 @@ static int ltc2497_result_and_measure(struct ltc2497core_driverdata *ddata, > } > > *val = (be32_to_cpu(st->buf) >> 14) - (1 << 17); > + > + /* > + * The part started a new conversion at the end of the above i2c > + * transfer, so if the address didn't change since the last call > + * everything is fine and we can return early. > + * If not (which should only happen when some sort of bulk > + * conversion is implemented) we have to program the new > + * address. Note that this probably fails as the conversion that > + * was triggered above is like not complete yet and the two > + * operations have to be done in a single transfer. > + */ > + if (ddata->addr_prev == address) > + return 0; > } > > ret = i2c_smbus_write_byte(st->client,
On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote: > On Mon, 15 Aug 2022 09:16:47 +0000 > Denys Zagorui <dzagorui@cisco.com> wrote: > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > After the result of the previous conversion is read the chip > > automatically starts a new conversion and doesn't accept new i2c > > transfers until this conversion is completed which makes the function > > return failure. > > That's rather nasty. > > Could we add a cheeky sleep in the other path to ensure there is always > time for the conversion to be done? Not ideal, but might ensure > there isn't a known problem path without introducing much complexity. FTR: While the patch was originally authored by me, I don't currently have access to a machine with that chip. So currently there will be no incentive on my side to address this feedback. Best regards Uwe
On Mon, 12 Sep 2022 12:46:31 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Sat, Aug 20, 2022 at 01:06:48PM +0100, Jonathan Cameron wrote: > > On Mon, 15 Aug 2022 09:16:47 +0000 > > Denys Zagorui <dzagorui@cisco.com> wrote: > > > > > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > > > After the result of the previous conversion is read the chip > > > automatically starts a new conversion and doesn't accept new i2c > > > transfers until this conversion is completed which makes the function > > > return failure. > > > > That's rather nasty. > > > > Could we add a cheeky sleep in the other path to ensure there is always > > time for the conversion to be done? Not ideal, but might ensure > > there isn't a known problem path without introducing much complexity. > > FTR: While the patch was originally authored by me, I don't currently > have access to a machine with that chip. So currently there will be no > incentive on my side to address this feedback. I'm not keen to keep changes to this driver queued up on improving this patch. Hence applied to the togreg branch of iio.git and I'll push that out as testing shortly for the autobuilders to poke at it. I have also marked it for stable. Thanks, Jonathan > > Best regards > Uwe >
diff --git a/drivers/iio/adc/ltc2497.c b/drivers/iio/adc/ltc2497.c index f7c786f37ceb..78b93c99cc47 100644 --- a/drivers/iio/adc/ltc2497.c +++ b/drivers/iio/adc/ltc2497.c @@ -41,6 +41,19 @@ static int ltc2497_result_and_measure(struct ltc2497core_driverdata *ddata, } *val = (be32_to_cpu(st->buf) >> 14) - (1 << 17); + + /* + * The part started a new conversion at the end of the above i2c + * transfer, so if the address didn't change since the last call + * everything is fine and we can return early. + * If not (which should only happen when some sort of bulk + * conversion is implemented) we have to program the new + * address. Note that this probably fails as the conversion that + * was triggered above is like not complete yet and the two + * operations have to be done in a single transfer. + */ + if (ddata->addr_prev == address) + return 0; } ret = i2c_smbus_write_byte(st->client,