| Message ID | 20221023132302.911644-24-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: accel: Convert to i2c's .probe_new | expand |
On Sun, 23 Oct 2022 15:23:02 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Applied. For the cases where and i2c_client_get_device_id() type call would be useful, I'd like you to explore that approach as it'll reduce the refactoring needed and is generally neater. Jonathan > --- > drivers/iio/light/vl6180.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c > index d47a4f6f4e87..8b56df26c59e 100644 > --- a/drivers/iio/light/vl6180.c > +++ b/drivers/iio/light/vl6180.c > @@ -493,8 +493,7 @@ static int vl6180_init(struct vl6180_data *data) > return vl6180_hold(data, false); > } > > -static int vl6180_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int vl6180_probe(struct i2c_client *client) > { > struct vl6180_data *data; > struct iio_dev *indio_dev; > @@ -539,7 +538,7 @@ static struct i2c_driver vl6180_driver = { > .name = VL6180_DRV_NAME, > .of_match_table = vl6180_of_match, > }, > - .probe = vl6180_probe, > + .probe_new = vl6180_probe, > .id_table = vl6180_id, > }; >
diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c index d47a4f6f4e87..8b56df26c59e 100644 --- a/drivers/iio/light/vl6180.c +++ b/drivers/iio/light/vl6180.c @@ -493,8 +493,7 @@ static int vl6180_init(struct vl6180_data *data) return vl6180_hold(data, false); } -static int vl6180_probe(struct i2c_client *client, - const struct i2c_device_id *id) +static int vl6180_probe(struct i2c_client *client) { struct vl6180_data *data; struct iio_dev *indio_dev; @@ -539,7 +538,7 @@ static struct i2c_driver vl6180_driver = { .name = VL6180_DRV_NAME, .of_match_table = vl6180_of_match, }, - .probe = vl6180_probe, + .probe_new = vl6180_probe, .id_table = vl6180_id, };
The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/iio/light/vl6180.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)