From patchwork Sun Oct 30 23:08:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Angelo Dureghello X-Patchwork-Id: 13025294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27AA7ECAAA1 for ; Sun, 30 Oct 2022 23:09:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229500AbiJ3XJp (ORCPT ); Sun, 30 Oct 2022 19:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiJ3XJo (ORCPT ); Sun, 30 Oct 2022 19:09:44 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28F962DF7 for ; Sun, 30 Oct 2022 16:09:43 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id t25so25523437ejb.8 for ; Sun, 30 Oct 2022 16:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timesys-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4fVJDdaJs+pMyCBTfQ4LllzvxRPlIZqaCasQi2qPwf4=; b=Tb1TnA0Ctn7Gi7fDQa70ZRRhMkE99H4mG0IGhezGRxkrvsCAuPpq3m1JGFBQmNGiqZ OniSt5k+vmQ3LN7euS9qbDjE8LMhlKWW4XtEXcbwDx5nV9gDIgaUuRCYmc9t+F5KOQJj iXdWI+4lgJ5XE4RAm+u+8AgEitNB5gYu2QnoH7cLSIq/wKghRNamUdFwrcXhvx7g4Ol8 Bt5+YTbzOy/174fZSxfizoFObT6EmTYbzdSeqCAFrq8HHxP5rZToV3S6UCKgT4igCCSz X11fhN3MCDsIjHq4fxf0oiF7x98AsmTNje7cg/UCGq4W5wWYbqNt3L8oN/vxogkbG1iJ sseQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4fVJDdaJs+pMyCBTfQ4LllzvxRPlIZqaCasQi2qPwf4=; b=2/KO8e8lpyGUjvtk7jimoAUNn7v13lwVzjEeVJ2uebvEw7Mg47RQlsTV5A4Ob2yTw6 5s4wcxWdeBgm5LFTHmg2+pZqkKflP36jjOAWzeXW7W/ev0fqkSzZKuIF6A01htHZTzFD SxykqhzmA0FEFWSAttK3ncbt6UG9B5PruQuxnDmOS0zuH0G6zmZNIAs+HOt5NWNJY/FV 23BSje4zhFUgE6vTOZvTEQpG40je223Vs44E0oNwlanzvZqj3curDfpkz/0XWX5bq+dA abcbKEPblnzLKTmIt+iGXRm5Uutl/IpaXdqXUBLTc5MbFwYyrV/N1tn2SlgvYZhBBtUx c4qg== X-Gm-Message-State: ACrzQf2in4j5ecHhSqOG/lbuijtjAd/aVQiHWIuOXKJqTm9NT6usqHns yFBkQJn86XxGjxT9j1ka1pPtkKx0UJShnRxW X-Google-Smtp-Source: AMsMyM6cIoBt7gMO4igkTrg/oYYheatUUCm7bcgHCKAAoBG0o/9/s66Zfd72SSisHUZTpdcaTRFnmQ== X-Received: by 2002:a17:906:8475:b0:7ad:c04:d3cf with SMTP id hx21-20020a170906847500b007ad0c04d3cfmr9699793ejc.463.1667171381680; Sun, 30 Oct 2022 16:09:41 -0700 (PDT) Received: from localhost.localdomain (host-87-0-236-69.retail.telecomitalia.it. [87.0.236.69]) by smtp.gmail.com with ESMTPSA id ay18-20020a056402203200b00459cf672a65sm2563962edb.71.2022.10.30.16.09.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 16:09:41 -0700 (PDT) From: Angelo Dureghello To: jic23@kernel.org, william.gray@linaro.org Cc: linux-iio@vger.kernel.org, Angelo Dureghello Subject: [PATCH v2] iio: dac: add support for max5522 Date: Mon, 31 Oct 2022 00:08:13 +0100 Message-Id: <20221030230813.460021-1-angelo.dureghello@timesys.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add initial support for DAC max5522. Tested writing DAC A and B with some values, from 0 to 1023, measured output voltages, driver works properly. Additions for max5523/24/25 will follow. --- Changes for v.2 - fix commit message - Kconfig, fix depends and select - Kconfig, fix typo - fix include alphabetical order - remove sysfs includes - fix MAX5522_REG_DATA macro - use devm_ as much as possible - add regulator_enable - remove useless code - remove commas after structure initializers and null terminators - change to use simplier module_spi_driver - get id->name from device info structure - regulator voltage read always from read_raw (no cache) Signed-off-by: Angelo Dureghello --- drivers/iio/dac/Kconfig | 13 +++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/max5522.c | 198 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 212 insertions(+) create mode 100644 drivers/iio/dac/max5522.c diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 80521bd28d0f..6c49523fe357 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -357,6 +357,19 @@ config MAX517 This driver can also be built as a module. If so, the module will be called max517. +config MAX5522 + tristate "Maxim MAX5522 DAC driver" + depends on SPI_MASTER + select REGMAP_SPI + help + Say Y here if you want to build a driver for the Maxim MAX5522. + + MAX5522 is a dual, ultra-low-power, 10-Bit, voltage-output + digital to analog converter (DAC) offering rail-to-rail buffered + voltage outputs. + + If compiled as a module, it will be called max5522. + config MAX5821 tristate "Maxim MAX5821 DAC driver" depends on I2C diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index ec3e42713f00..6c74fea21736 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -38,6 +38,7 @@ obj-$(CONFIG_LTC2632) += ltc2632.o obj-$(CONFIG_LTC2688) += ltc2688.o obj-$(CONFIG_M62332) += m62332.o obj-$(CONFIG_MAX517) += max517.o +obj-$(CONFIG_MAX5522) += max5522.o obj-$(CONFIG_MAX5821) += max5821.o obj-$(CONFIG_MCP4725) += mcp4725.o obj-$(CONFIG_MCP4922) += mcp4922.o diff --git a/drivers/iio/dac/max5522.c b/drivers/iio/dac/max5522.c new file mode 100644 index 000000000000..dda822843542 --- /dev/null +++ b/drivers/iio/dac/max5522.c @@ -0,0 +1,198 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Maxim MAX5522 + * Dual, Ultra-Low-Power 10-Bit, Voltage-Output DACs + * + * Copyright 2022 Timesys Corp. + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#define MAX5522_MAX_ADDR 15 +#define MAX5522_CTRL_NONE 0 +#define MAX5522_CTRL_LOAD_IN_A 9 +#define MAX5522_CTRL_LOAD_IN_B 10 + +#define MAX5522_REG_DATA(x) ((x) + MAX5522_CTRL_LOAD_IN_A) + +struct max5522_chip_info { + const char *name; + const struct iio_chan_spec *channels; + unsigned int num_channels; +}; + +struct max5522_state { + struct regmap *regmap; + const struct max5522_chip_info *chip_info; + unsigned short dac_cache[2]; + unsigned int vrefin_mv; + struct regulator *vrefin_reg; +}; + +#define MAX5522_CHANNEL(chan) { \ + .type = IIO_VOLTAGE, \ + .indexed = 1, \ + .output = 1, \ + .channel = chan, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ + BIT(IIO_CHAN_INFO_SCALE), \ + .scan_type = { \ + .sign = 'u', \ + .realbits = 10, \ + .storagebits = 16, \ + .shift = 2, \ + } \ +} + +const struct iio_chan_spec max5522_channels[] = { + MAX5522_CHANNEL(0), + MAX5522_CHANNEL(1), +}; + +enum max5522_type { + ID_MAX5522, +}; + +static const struct max5522_chip_info max5522_chip_info_tbl[] = { + [ID_MAX5522] = { + .name = "max5522", + .channels = max5522_channels, + .num_channels = 2, + }, +}; + +static inline int max5522_info_to_reg(struct iio_chan_spec const *chan) +{ + return MAX5522_REG_DATA(chan->channel); +} + +static int max5522_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, int *val, int *val2, long info) +{ + struct max5522_state *state = iio_priv(indio_dev); + int ret; + + switch (info) { + case IIO_CHAN_INFO_RAW: + *val = state->dac_cache[chan->channel]; + return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + ret = regulator_get_voltage(state->vrefin_reg); + if (ret < 0) + return -EINVAL; + state->vrefin_mv = ret / 1000; + *val = state->vrefin_mv; + *val2 = 10; + return IIO_VAL_FRACTIONAL_LOG2; + default: + return -EINVAL; + } + + return -EINVAL; +} + +static int max5522_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, int val, int val2, long info) +{ + struct max5522_state *state = iio_priv(indio_dev); + int rval; + + if (val > 1023 || val < 0) + return -EINVAL; + + rval = regmap_write(state->regmap, max5522_info_to_reg(chan), + val << chan->scan_type.shift); + if (rval < 0) + return rval; + + state->dac_cache[chan->channel] = val; + + return 0; +} + +static const struct iio_info max5522_info = { + .read_raw = max5522_read_raw, + .write_raw = max5522_write_raw, +}; + +static const struct regmap_config max5522_regmap_config = { + .reg_bits = 4, + .val_bits = 12, + .max_register = MAX5522_MAX_ADDR, +}; + +static int max5522_spi_probe(struct spi_device *spi) +{ + const struct spi_device_id *id = spi_get_device_id(spi); + struct iio_dev *indio_dev; + struct max5522_state *state; + int ret; + + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*state)); + if (indio_dev == NULL) { + dev_err(&spi->dev, "failed to allocate iio device\n"); + return -ENOMEM; + } + + state = iio_priv(indio_dev); + state->chip_info = &max5522_chip_info_tbl[id->driver_data]; + + state->vrefin_reg = devm_regulator_get(&spi->dev, "vrefin"); + if (IS_ERR(state->vrefin_reg)) + return dev_err_probe(&spi->dev, PTR_ERR(state->vrefin_reg), + "Vrefin regulator not specified\n"); + + ret = regulator_enable(state->vrefin_reg); + if (ret) { + return dev_err_probe(&spi->dev, ret, + "Failed to enable vref regulators\n"); + } + + state->regmap = devm_regmap_init_spi(spi, &max5522_regmap_config); + + if (IS_ERR(state->regmap)) + return PTR_ERR(state->regmap); + + indio_dev->info = &max5522_info; + indio_dev->modes = INDIO_DIRECT_MODE; + indio_dev->channels = max5522_channels; + indio_dev->num_channels = ARRAY_SIZE(max5522_channels); + indio_dev->name = max5522_chip_info_tbl[ID_MAX5522].name; + + return devm_iio_device_register(&spi->dev, indio_dev); +} + +static const struct spi_device_id max5522_ids[] = { + { "max5522", ID_MAX5522 }, + {} +}; +MODULE_DEVICE_TABLE(spi, max5522_ids); + + +static const struct of_device_id max5522_of_match[] = { + { .compatible = "maxim,max5522" }, + {} +}; + +MODULE_DEVICE_TABLE(of, max5522_of_match); + +static struct spi_driver max5522_spi_driver = { + .driver = { + .name = "max5522", + .of_match_table = max5522_of_match, + }, + .probe = max5522_spi_probe, + .id_table = max5522_ids, +}; +module_spi_driver(max5522_spi_driver); + +MODULE_AUTHOR("Angelo Dureghello