diff mbox series

[v6,2/7] power: supply: fix wrong interpretation of register value

Message ID 20221123175425.564042-3-sravanhome@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series Add support for mp2733 battery charger | expand

Commit Message

saravanan sekar Nov. 23, 2022, 5:54 p.m. UTC
Fix the switch cases to match the register value.

Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
---
 drivers/power/supply/mp2629_charger.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sebastian Reichel Nov. 24, 2022, 9:45 p.m. UTC | #1
Hi,

On Wed, Nov 23, 2022 at 06:54:20PM +0100, Saravanan Sekar wrote:
> Fix the switch cases to match the register value.
> 
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  drivers/power/supply/mp2629_charger.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/mp2629_charger.c b/drivers/power/supply/mp2629_charger.c
> index bf9c27b463a8..46d620bd23b9 100644
> --- a/drivers/power/supply/mp2629_charger.c
> +++ b/drivers/power/supply/mp2629_charger.c
> @@ -284,10 +284,10 @@ static int mp2629_charger_battery_get_prop(struct power_supply *psy,
>  			val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
>  			break;
>  		case 0x01:
> -		case 0x10:
> +		case 0x02:
>  			val->intval = POWER_SUPPLY_STATUS_CHARGING;
>  			break;
> -		case 0x11:
> +		case 0x03:
>  			val->intval = POWER_SUPPLY_STATUS_FULL;
>  		}
>  		break;
> @@ -305,7 +305,7 @@ static int mp2629_charger_battery_get_prop(struct power_supply *psy,
>  		case 0x01:
>  			val->intval = POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
>  			break;
> -		case 0x10:
> +		case 0x02:
>  			val->intval = POWER_SUPPLY_CHARGE_TYPE_STANDARD;
>  			break;
>  		default:
> -- 
> 2.34.1
>
diff mbox series

Patch

diff --git a/drivers/power/supply/mp2629_charger.c b/drivers/power/supply/mp2629_charger.c
index bf9c27b463a8..46d620bd23b9 100644
--- a/drivers/power/supply/mp2629_charger.c
+++ b/drivers/power/supply/mp2629_charger.c
@@ -284,10 +284,10 @@  static int mp2629_charger_battery_get_prop(struct power_supply *psy,
 			val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
 			break;
 		case 0x01:
-		case 0x10:
+		case 0x02:
 			val->intval = POWER_SUPPLY_STATUS_CHARGING;
 			break;
-		case 0x11:
+		case 0x03:
 			val->intval = POWER_SUPPLY_STATUS_FULL;
 		}
 		break;
@@ -305,7 +305,7 @@  static int mp2629_charger_battery_get_prop(struct power_supply *psy,
 		case 0x01:
 			val->intval = POWER_SUPPLY_CHARGE_TYPE_TRICKLE;
 			break;
-		case 0x10:
+		case 0x02:
 			val->intval = POWER_SUPPLY_CHARGE_TYPE_STANDARD;
 			break;
 		default: