diff mbox series

iio: adc: vf610_adc: Convert to use sysfs_emit_at() API

Message ID 202212071534513812390@zte.com.cn (mailing list archive)
State Changes Requested
Headers show
Series iio: adc: vf610_adc: Convert to use sysfs_emit_at() API | expand

Commit Message

ye.xingchen@zte.com.cn Dec. 7, 2022, 7:34 a.m. UTC 
From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/iio/adc/vf610_adc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bough Chen Dec. 9, 2022, 8:28 a.m. UTC | #1 
> -----Original Message-----
> From: ye.xingchen@zte.com.cn <ye.xingchen@zte.com.cn>
> Sent: 2022年12月7日 15:35
> To: jic23@kernel.org
> Cc: Bough Chen <haibo.chen@nxp.com>; andriy.shevchenko@linux.intel.com;
> lars@metafoo.de; linux-iio@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] iio: adc: vf610_adc: Convert to use sysfs_emit_at() API
> 
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show() should
> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
> returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Haibo Chen <haibo.chen@nxp.com>

Best Regards
Haibo Chen
> ---
>  drivers/iio/adc/vf610_adc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> ae31aafd2653..dbf80f5f674b 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -606,8 +606,7 @@ static ssize_t vf610_show_samp_freq_avail(struct
> device *dev,
>  	int i;
> 
>  	for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
> -		len += scnprintf(buf + len, PAGE_SIZE - len,
> -			"%u ", info->sample_freq_avail[i]);
> +		len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);
> 
>  	/* replace trailing space by newline */
>  	buf[len - 1] = '\n';
> --
> 2.25.1
diff mbox series

Patch

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index ae31aafd2653..dbf80f5f674b 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -606,8 +606,7 @@  static ssize_t vf610_show_samp_freq_avail(struct device *dev,
 	int i;

 	for (i = 0; i < ARRAY_SIZE(info->sample_freq_avail); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len,
-			"%u ", info->sample_freq_avail[i]);
+		len += sysfs_emit_at(buf, len, "%u ", info->sample_freq_avail[i]);

 	/* replace trailing space by newline */
 	buf[len - 1] = '\n';