diff mbox series

[2/4] counter: intel: Depend on X86

Message ID 20230108074750.443705-2-pbrobinson@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [1/4] counter: Sort the Kconfig entries alphabetically | expand

Commit Message

Peter Robinson Jan. 8, 2023, 7:47 a.m. UTC
Limite the Intel counter driver to X86, it doesn't
make sense to build it for all arches if the couner
subsystem is enabled.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron Jan. 8, 2023, 11:11 a.m. UTC | #1
On Sun,  8 Jan 2023 07:47:48 +0000
Peter Robinson <pbrobinson@gmail.com> wrote:

> Limite the Intel counter driver to X86, it doesn't
> make sense to build it for all arches if the couner
> subsystem is enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Probably better to go with
depends on X86 || COMPILE_TEST

Sometimes other compilers throw up issues that are missed by those
targeting a specific architecture.  Obviously this is less important
for x86 drivers than more obscure platforms, but meh the principle still
stands.

Jonathan


> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 508d857808e9..011e6af840fc 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -41,6 +41,7 @@ config FTM_QUADDEC
>  
>  config INTEL_QEP
>  	tristate "Intel Quadrature Encoder Peripheral driver"
> +	depends on X86
>  	depends on PCI
>  	help
>  	  Select this option to enable the Intel Quadrature Encoder Peripheral
William Breathitt Gray Jan. 13, 2023, 7:52 p.m. UTC | #2
On Sun, Jan 08, 2023 at 07:47:48AM +0000, Peter Robinson wrote:
> Limite the Intel counter driver to X86, it doesn't
> make sense to build it for all arches if the couner

I'll fix the "Limite" and "couner" typos as I pick up this patch.

> subsystem is enabled.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray
diff mbox series

Patch

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 508d857808e9..011e6af840fc 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -41,6 +41,7 @@  config FTM_QUADDEC
 
 config INTEL_QEP
 	tristate "Intel Quadrature Encoder Peripheral driver"
+	depends on X86
 	depends on PCI
 	help
 	  Select this option to enable the Intel Quadrature Encoder Peripheral