diff mbox series

[3/4] counter: FTM quad: Depend on the Layerscape SoC

Message ID 20230108074750.443705-3-pbrobinson@gmail.com (mailing list archive)
State Handled Elsewhere
Headers show
Series [1/4] counter: Sort the Kconfig entries alphabetically | expand

Commit Message

Peter Robinson Jan. 8, 2023, 7:47 a.m. UTC
At the moment only the Freescale LS1021A is the only HW that
supports this IP block so add an appropriate dependency and
compile test.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/counter/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron Jan. 8, 2023, 11:30 a.m. UTC | #1
On Sun,  8 Jan 2023 07:47:49 +0000
Peter Robinson <pbrobinson@gmail.com> wrote:

> At the moment only the Freescale LS1021A is the only HW that
> supports this IP block so add an appropriate dependency and
> compile test.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Ah I see you had deliberately not put COMPILE_TEST for the x86
one - fair enough I guess.

For this one, the IP is fairly generic and I think appears on other
chips - not sure they are supported by Linux however.  Maybe it's
fine to limit it like this for now and see if anyone shouts...

Jonathan


> ---
>  drivers/counter/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 011e6af840fc..ef78386ccd2e 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -31,6 +31,7 @@ config 104_QUAD_8
>  
>  config FTM_QUADDEC
>  	tristate "Flex Timer Module Quadrature decoder driver"
> +	depends on SOC_LS1021A || COMPILE_TEST
>  	depends on HAS_IOMEM && OF
>  	help
>  	  Select this option to enable the Flex Timer Quadrature decoder
Peter Robinson Jan. 8, 2023, 11:58 a.m. UTC | #2
On Sun, Jan 8, 2023 at 11:17 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun,  8 Jan 2023 07:47:49 +0000
> Peter Robinson <pbrobinson@gmail.com> wrote:
>
> > At the moment only the Freescale LS1021A is the only HW that
> > supports this IP block so add an appropriate dependency and
> > compile test.
> >
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> Ah I see you had deliberately not put COMPILE_TEST for the x86
> one - fair enough I guess.
>
> For this one, the IP is fairly generic and I think appears on other
> chips - not sure they are supported by Linux however.  Maybe it's
> fine to limit it like this for now and see if anyone shouts...

It's currently only referenced in arch/arm/boot/dts/ls1021a.dtsi and I
don't have access to all the Layerscape docs to verify the IP, no
doubt there's others but they may need other changes for different IP
revs etc hence why I specified that one.

> Jonathan
>
>
> > ---
> >  drivers/counter/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> > index 011e6af840fc..ef78386ccd2e 100644
> > --- a/drivers/counter/Kconfig
> > +++ b/drivers/counter/Kconfig
> > @@ -31,6 +31,7 @@ config 104_QUAD_8
> >
> >  config FTM_QUADDEC
> >       tristate "Flex Timer Module Quadrature decoder driver"
> > +     depends on SOC_LS1021A || COMPILE_TEST
> >       depends on HAS_IOMEM && OF
> >       help
> >         Select this option to enable the Flex Timer Quadrature decoder
>
William Breathitt Gray Jan. 13, 2023, 7:53 p.m. UTC | #3
On Sun, Jan 08, 2023 at 07:47:49AM +0000, Peter Robinson wrote:
> At the moment only the Freescale LS1021A is the only HW that
> supports this IP block so add an appropriate dependency and
> compile test.
> 
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied to counter-next, thanks.

William Breathitt Gray
diff mbox series

Patch

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 011e6af840fc..ef78386ccd2e 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -31,6 +31,7 @@  config 104_QUAD_8
 
 config FTM_QUADDEC
 	tristate "Flex Timer Module Quadrature decoder driver"
+	depends on SOC_LS1021A || COMPILE_TEST
 	depends on HAS_IOMEM && OF
 	help
 	  Select this option to enable the Flex Timer Quadrature decoder