From patchwork Fri Jan 13 13:33:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anastasia Belova X-Patchwork-Id: 13100759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50E0C67871 for ; Fri, 13 Jan 2023 13:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241483AbjAMNjX (ORCPT ); Fri, 13 Jan 2023 08:39:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241832AbjAMNim (ORCPT ); Fri, 13 Jan 2023 08:38:42 -0500 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76E153C3A0; Fri, 13 Jan 2023 05:33:27 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id D91101863FB1; Fri, 13 Jan 2023 16:33:23 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YD6YgPiEQKEc; Fri, 13 Jan 2023 16:33:23 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 936301863F94; Fri, 13 Jan 2023 16:33:23 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C0a-tRBm6QT3; Fri, 13 Jan 2023 16:33:23 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.20.58]) by mail.astralinux.ru (Postfix) with ESMTPSA id 095ED1863C69; Fri, 13 Jan 2023 16:33:22 +0300 (MSK) From: Anastasia Belova To: Tomasz Duszynski Cc: Anastasia Belova , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] iio: chemical: scd30: Add check for NULL in scd30_i2c_command Date: Fri, 13 Jan 2023 16:33:20 +0300 Message-Id: <20230113133320.7531-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Check rsp for NULL-pointer before dereferencing. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e510190e0139 ("iio: chemical: scd30: add I2C interface driver") Signed-off-by: Anastasia Belova --- drivers/iio/chemical/scd30_i2c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/chemical/scd30_i2c.c b/drivers/iio/chemical/scd30_i2c.c index bae479a4721f..84baf67fc0ce 100644 --- a/drivers/iio/chemical/scd30_i2c.c +++ b/drivers/iio/chemical/scd30_i2c.c @@ -101,8 +101,10 @@ static int scd30_i2c_command(struct scd30_state *state, enum scd30_cmd cmd, u16 return -EIO; } - *rsp++ = buf[i]; - *rsp++ = buf[i + 1]; + if (rsp) { + *rsp++ = buf[i]; + *rsp++ = buf[i + 1]; + } } return 0;