| Message ID | 20230115173958.134201-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: iio: dac: Maxim max5522 DAC | expand |
On 15/01/2023 18:39, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Add binding Doc for this SPI DAC. > > The driver was perviously posted but was missing the DT binding document. > https://lore.kernel.org/all/20221106165928.223318-1-angelo.dureghello@timesys.com/ > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Angelo Dureghello <angelo.dureghello@timesys.com> > > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Jonathan, thanks a lot, and sorry, looks like i forgot this out. Reviewed-by: Angelo Dureghello <angelo.dureghello@timesys.com> On Sun, Jan 15, 2023 at 6:26 PM Jonathan Cameron <jic23@kernel.org> wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Add binding Doc for this SPI DAC. > > The driver was perviously posted but was missing the DT binding document. > https://lore.kernel.org/all/20221106165928.223318-1-angelo.dureghello@timesys.com/ > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Angelo Dureghello <angelo.dureghello@timesys.com> > > --- > > As it has been a few months and I don't want to end up not taking the driver > simply because it lacked this simple binding doc, I've written one. > > .../bindings/iio/dac/maxim,max5522.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml > new file mode 100644 > index 000000000000..24830f56c501 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs > + > +maintainers: > + - Angelo Dureghello <angelo.dureghello@timesys.com> > + - Jonathan Cameron <jic23@kernel.org> > + > +description: | > + Datasheet available at: > + https://www.analog.com/en/products/max5522.html > + > +properties: > + compatible: > + const: maxim,max5522 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + vrefin-supply: true > + > +required: > + - compatible > + - reg > + - vrefin-supply > + > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + dac@0 { > + compatible = "maxim,max5522"; > + reg = <0>; > + vrefin-supply = <&vref>; > + }; > + }; > +... > -- > 2.39.0 > -- Angelo Dureghello Timesys e. angelo.dureghello@timesys.com
On Mon, 16 Jan 2023 23:46:35 +0100 Angelo Dureghello <angelo.dureghello@timesys.com> wrote: > Hi Jonathan, > > thanks a lot, and sorry, looks like i forgot this out. No problem! > > Reviewed-by: Angelo Dureghello <angelo.dureghello@timesys.com> Applied the driver an this binding doc to the togreg branch of iio.git which will initially get pushed out as testing for 0-day to see if it can find anything we missed. Thanks, Jonathan > > > On Sun, Jan 15, 2023 at 6:26 PM Jonathan Cameron <jic23@kernel.org> wrote: > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Add binding Doc for this SPI DAC. > > > > The driver was perviously posted but was missing the DT binding document. > > https://lore.kernel.org/all/20221106165928.223318-1-angelo.dureghello@timesys.com/ > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Angelo Dureghello <angelo.dureghello@timesys.com> > > > > --- > > > > As it has been a few months and I don't want to end up not taking the driver > > simply because it lacked this simple binding doc, I've written one. > > > > .../bindings/iio/dac/maxim,max5522.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml > > new file mode 100644 > > index 000000000000..24830f56c501 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs > > + > > +maintainers: > > + - Angelo Dureghello <angelo.dureghello@timesys.com> > > + - Jonathan Cameron <jic23@kernel.org> > > + > > +description: | > > + Datasheet available at: > > + https://www.analog.com/en/products/max5522.html > > + > > +properties: > > + compatible: > > + const: maxim,max5522 > > + > > + reg: > > + maxItems: 1 > > + > > + vdd-supply: true > > + vrefin-supply: true > > + > > +required: > > + - compatible > > + - reg > > + - vrefin-supply > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + dac@0 { > > + compatible = "maxim,max5522"; > > + reg = <0>; > > + vrefin-supply = <&vref>; > > + }; > > + }; > > +... > > -- > > 2.39.0 > > > > > -- > Angelo Dureghello > Timesys > e. angelo.dureghello@timesys.com
Hi Jonathan, On Sat, Jan 21, 2023 at 6:46 PM Jonathan Cameron <jic23@kernel.org> wrote: > > On Mon, 16 Jan 2023 23:46:35 +0100 > Angelo Dureghello <angelo.dureghello@timesys.com> wrote: > > > Hi Jonathan, > > > > thanks a lot, and sorry, looks like i forgot this out. > No problem! > > > > Reviewed-by: Angelo Dureghello <angelo.dureghello@timesys.com> > Applied the driver an this binding doc to the togreg branch of iio.git > which will initially get pushed out as testing for 0-day to see if > it can find anything we missed. > > Thanks, > > Jonathan Great, thanks !
diff --git a/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml new file mode 100644 index 000000000000..24830f56c501 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/maxim,max5522.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/dac/maxim,max5522.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim Integrated MAX5522 Dual 10-bit Voltage-Output SPI DACs + +maintainers: + - Angelo Dureghello <angelo.dureghello@timesys.com> + - Jonathan Cameron <jic23@kernel.org> + +description: | + Datasheet available at: + https://www.analog.com/en/products/max5522.html + +properties: + compatible: + const: maxim,max5522 + + reg: + maxItems: 1 + + vdd-supply: true + vrefin-supply: true + +required: + - compatible + - reg + - vrefin-supply + +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + +examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + dac@0 { + compatible = "maxim,max5522"; + reg = <0>; + vrefin-supply = <&vref>; + }; + }; +...