diff mbox series

[v2] drivers: iio: remove dead code in at91_adc_probe

Message ID 20230310113158.428940-1-chengziqiu@hust.edu.cn (mailing list archive)
State Changes Requested
Headers show
Series [v2] drivers: iio: remove dead code in at91_adc_probe | expand

Commit Message

Cheng Ziqiu March 10, 2023, 11:31 a.m. UTC 
From the comment of platform_get_irq, it only returns non-zero IRQ
number and negative error number, other than zero.

Fix this by removing the if condition.

Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
---
v1->v2: Change commit message from SoB to Reviewed-by.
 drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Eugen Hristev March 10, 2023, 11:59 a.m. UTC | #1 
On 3/10/23 13:31, Cheng Ziqiu wrote:
>  From the comment of platform_get_irq, it only returns non-zero IRQ
> number and negative error number, other than zero.
> 
> Fix this by removing the if condition.
> 
> Signed-off-by: Cheng Ziqiu <chengziqiu@hust.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>

Hi and thank you for the patch,

Can you try to make the subject adhere to
subsystem: area: driver: change

e.g.
iio: adc: at91-sama5d2_adc: remove dead code...

Eugen


> ---
> v1->v2: Change commit message from SoB to Reviewed-by.
>   drivers/iio/adc/at91-sama5d2_adc.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
> index 50d02e5fc6fc..168399092590 100644
> --- a/drivers/iio/adc/at91-sama5d2_adc.c
> +++ b/drivers/iio/adc/at91-sama5d2_adc.c
> @@ -2400,12 +2400,8 @@ static int at91_adc_probe(struct platform_device *pdev)
>   	st->dma_st.phys_addr = res->start;
>   
>   	st->irq = platform_get_irq(pdev, 0);
> -	if (st->irq <= 0) {
> -		if (!st->irq)
> -			st->irq = -ENXIO;
> -
> +	if (st->irq < 0)
>   		return st->irq;
> -	}
>   
>   	st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
>   	if (IS_ERR(st->per_clk))
diff mbox series

Patch

diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c
index 50d02e5fc6fc..168399092590 100644
--- a/drivers/iio/adc/at91-sama5d2_adc.c
+++ b/drivers/iio/adc/at91-sama5d2_adc.c
@@ -2400,12 +2400,8 @@  static int at91_adc_probe(struct platform_device *pdev)
 	st->dma_st.phys_addr = res->start;
 
 	st->irq = platform_get_irq(pdev, 0);
-	if (st->irq <= 0) {
-		if (!st->irq)
-			st->irq = -ENXIO;
-
+	if (st->irq < 0)
 		return st->irq;
-	}
 
 	st->per_clk = devm_clk_get(&pdev->dev, "adc_clk");
 	if (IS_ERR(st->per_clk))