| Message ID | 20230312153429.371702-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] iio: dac: ad5755: mark OF related data as maybe unused | expand |
On Sun, 12 Mar 2023 16:34:27 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > The driver can be compile tested with !CONFIG_OF making certain data > unused (of_device_id is not used for device matching): > > drivers/iio/dac/ad5755.c:865:34: error: ‘ad5755_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. None. > > Although Jonathan expressed need of changes here, they are a bit too > invasive for me thus I am resending it only for completeness. > I understand therefore that patch might not be accepted. Hi Krzysztof, I'll leave it unapplied for now on basis I might get time in near future to do the more major refactor I'd like to see (and hack some testing together for it). If that looks unlikely I may pick this up later. It'll sit in patchwork until then making me feel guilty :) Thanks, Jonathan > --- > drivers/iio/dac/ad5755.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c > index beadfa938d2d..a6dc8a0bfc29 100644 > --- a/drivers/iio/dac/ad5755.c > +++ b/drivers/iio/dac/ad5755.c > @@ -862,7 +862,7 @@ static const struct spi_device_id ad5755_id[] = { > }; > MODULE_DEVICE_TABLE(spi, ad5755_id); > > -static const struct of_device_id ad5755_of_match[] = { > +static const struct of_device_id ad5755_of_match[] __maybe_unused = { > { .compatible = "adi,ad5755" }, > { .compatible = "adi,ad5755-1" }, > { .compatible = "adi,ad5757" },
diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c index beadfa938d2d..a6dc8a0bfc29 100644 --- a/drivers/iio/dac/ad5755.c +++ b/drivers/iio/dac/ad5755.c @@ -862,7 +862,7 @@ static const struct spi_device_id ad5755_id[] = { }; MODULE_DEVICE_TABLE(spi, ad5755_id); -static const struct of_device_id ad5755_of_match[] = { +static const struct of_device_id ad5755_of_match[] __maybe_unused = { { .compatible = "adi,ad5755" }, { .compatible = "adi,ad5755-1" }, { .compatible = "adi,ad5757" },
The driver can be compile tested with !CONFIG_OF making certain data unused (of_device_id is not used for device matching): drivers/iio/dac/ad5755.c:865:34: error: ‘ad5755_of_match’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. None. Although Jonathan expressed need of changes here, they are a bit too invasive for me thus I am resending it only for completeness. I understand therefore that patch might not be accepted. --- drivers/iio/dac/ad5755.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)