diff mbox series

iio: dac: ad5755: Add missing fwnode_handle_put()

Message ID 20230322035627.1856421-1-windhl@126.com (mailing list archive)
State Accepted
Headers show
Series iio: dac: ad5755: Add missing fwnode_handle_put() | expand

Commit Message

Liang He March 22, 2023, 3:56 a.m. UTC 
In ad5755_parse_fw(), we should add fwnode_handle_put()
when break out of the iteration device_for_each_child_node()
as it will automatically increase and decrease the refcounter.

Fixes: 3ac27afefd5d ("iio:dac:ad5755: Switch to generic firmware properties and drop pdata")
Signed-off-by: Liang He <windhl@126.com>
---
 drivers/iio/dac/ad5755.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Cameron April 1, 2023, 3:42 p.m. UTC | #1 
On Wed, 22 Mar 2023 11:56:27 +0800
Liang He <windhl@126.com> wrote:

> In ad5755_parse_fw(), we should add fwnode_handle_put()
> when break out of the iteration device_for_each_child_node()
> as it will automatically increase and decrease the refcounter.
> 
> Fixes: 3ac27afefd5d ("iio:dac:ad5755: Switch to generic firmware properties and drop pdata")
> Signed-off-by: Liang He <windhl@126.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.

Thanks,

Jonathan

> ---
>  drivers/iio/dac/ad5755.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> index beadfa938d2d..404865e35460 100644
> --- a/drivers/iio/dac/ad5755.c
> +++ b/drivers/iio/dac/ad5755.c
> @@ -802,6 +802,7 @@ static struct ad5755_platform_data *ad5755_parse_fw(struct device *dev)
>  	return pdata;
>  
>   error_out:
> +	fwnode_handle_put(pp);
>  	devm_kfree(dev, pdata);
>  	return NULL;
>  }
diff mbox series

Patch

diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
index beadfa938d2d..404865e35460 100644
--- a/drivers/iio/dac/ad5755.c
+++ b/drivers/iio/dac/ad5755.c
@@ -802,6 +802,7 @@  static struct ad5755_platform_data *ad5755_parse_fw(struct device *dev)
 	return pdata;
 
  error_out:
+	fwnode_handle_put(pp);
 	devm_kfree(dev, pdata);
 	return NULL;
 }