| Message ID | 20230722200718.142366-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Use i2c_get_match_data() instead of device_get_match_data() | expand |
On Sat, Jul 22, 2023 at 10:07 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > The .driver_data in adxl313_i2c_id[] for adxl312 and adxl314 is > wrong. Fix this issue by adding corresponding adxl31x_chip_info > data. > > Reported-by: Jonathan Cameron <jic23@kernel.org> > Closes: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230716175218.130557-3-biju.das.jz@bp.renesas.com/#25436658 Why not a link to lore? Closes: https://lore.kernel.org/all/20230722172832.04ad7738@jic23-huawei > Fixes: a7a1c60bc4c9 ("drivers: iio: accel: adxl312 and adxl314 support") > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v2 1/2] iio: accel: adxl313: Fix adxl313_i2c_id[] > table > > On Sat, Jul 22, 2023 at 10:07 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > The .driver_data in adxl313_i2c_id[] for adxl312 and adxl314 is wrong. > > Fix this issue by adding corresponding adxl31x_chip_info data. > > > > Reported-by: Jonathan Cameron <jic23@kernel.org> > > Closes: > > Why not a link to lore? OK, will use the link to lore. Cheers, Biju > > Closes: > > > Fixes: a7a1c60bc4c9 ("drivers: iio: accel: adxl312 and adxl314 > > support") > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
diff --git a/drivers/iio/accel/adxl313_i2c.c b/drivers/iio/accel/adxl313_i2c.c index 524327ea3663..e0a860ab9e58 100644 --- a/drivers/iio/accel/adxl313_i2c.c +++ b/drivers/iio/accel/adxl313_i2c.c @@ -40,8 +40,8 @@ static const struct regmap_config adxl31x_i2c_regmap_config[] = { static const struct i2c_device_id adxl313_i2c_id[] = { { .name = "adxl312", .driver_data = (kernel_ulong_t)&adxl31x_chip_info[ADXL312] }, - { .name = "adxl313", .driver_data = (kernel_ulong_t)&adxl31x_chip_info[ADXL312] }, - { .name = "adxl314", .driver_data = (kernel_ulong_t)&adxl31x_chip_info[ADXL312] }, + { .name = "adxl313", .driver_data = (kernel_ulong_t)&adxl31x_chip_info[ADXL313] }, + { .name = "adxl314", .driver_data = (kernel_ulong_t)&adxl31x_chip_info[ADXL314] }, { } };
The .driver_data in adxl313_i2c_id[] for adxl312 and adxl314 is wrong. Fix this issue by adding corresponding adxl31x_chip_info data. Reported-by: Jonathan Cameron <jic23@kernel.org> Closes: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230716175218.130557-3-biju.das.jz@bp.renesas.com/#25436658 Fixes: a7a1c60bc4c9 ("drivers: iio: accel: adxl312 and adxl314 support") Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/iio/accel/adxl313_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)