| Message ID | 20230804100938.100435-1-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] iio: adc: men_z188_adc: Remove redundant initialization owner in men_z188_driver | expand |
On Fri, 4 Aug 2023 18:09:38 +0800 Li Zetao <lizetao1@huawei.com> wrote: > The module_mcb_driver() will set "THIS_MODULE" to driver.owner when > register a mcb_driver, so it is redundant initialization to set > driver.owner in men_z188_driver statement. Remove it for clean code. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Applied to the togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/adc/men_z188_adc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c > index adc5ceaef8c9..198c7e68e0cf 100644 > --- a/drivers/iio/adc/men_z188_adc.c > +++ b/drivers/iio/adc/men_z188_adc.c > @@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(mcb, men_z188_ids); > static struct mcb_driver men_z188_driver = { > .driver = { > .name = "z188-adc", > - .owner = THIS_MODULE, > }, > .probe = men_z188_probe, > .remove = men_z188_remove,
diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c index adc5ceaef8c9..198c7e68e0cf 100644 --- a/drivers/iio/adc/men_z188_adc.c +++ b/drivers/iio/adc/men_z188_adc.c @@ -161,7 +161,6 @@ MODULE_DEVICE_TABLE(mcb, men_z188_ids); static struct mcb_driver men_z188_driver = { .driver = { .name = "z188-adc", - .owner = THIS_MODULE, }, .probe = men_z188_probe, .remove = men_z188_remove,
The module_mcb_driver() will set "THIS_MODULE" to driver.owner when register a mcb_driver, so it is redundant initialization to set driver.owner in men_z188_driver statement. Remove it for clean code. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- drivers/iio/adc/men_z188_adc.c | 1 - 1 file changed, 1 deletion(-)