| Message ID | 20231023123542.582392-4-ramona.gradinariu@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: imu: adis: Use spi cs inactive delay | expand |
On 23/10/2023 14:35, Ramona Gradinariu wrote: > Add 'spi-cs-inactive-delay-ns' property. This we see from the diff. Commit should explain: Why? > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> > --- > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > index 4e43c80e5119..3691c0be4f9d 100644 > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > @@ -25,6 +25,11 @@ properties: > > spi-cpol: true > > + spi-cs-inactive-delay-ns: > + minimum: 16000 > + description: > + If not explicitly set in the device tree, the driver will set it to 16us. Why do you even need it here? Best regards, Krzysztof
On Mon, 23 Oct 2023 15:22:30 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 23/10/2023 14:35, Ramona Gradinariu wrote: > > Add 'spi-cs-inactive-delay-ns' property. > > This we see from the diff. Commit should explain: Why? > > > > > Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> > > --- > > Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > index 4e43c80e5119..3691c0be4f9d 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml > > @@ -25,6 +25,11 @@ properties: > > > > spi-cpol: true > > > > + spi-cs-inactive-delay-ns: > > + minimum: 16000 > > + description: > > + If not explicitly set in the device tree, the driver will set it to 16us. > > Why do you even need it here? Along side that, if you have a default default: xxxx rather than in the description. > > Best regards, > Krzysztof > >
diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml index 4e43c80e5119..3691c0be4f9d 100644 --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml @@ -25,6 +25,11 @@ properties: spi-cpol: true + spi-cs-inactive-delay-ns: + minimum: 16000 + description: + If not explicitly set in the device tree, the driver will set it to 16us. + interrupts: maxItems: 1
Add 'spi-cs-inactive-delay-ns' property. Signed-off-by: Ramona Gradinariu <ramona.gradinariu@analog.com> --- Documentation/devicetree/bindings/iio/imu/adi,adis16460.yaml | 5 +++++ 1 file changed, 5 insertions(+)