| Message ID | 20231109090456.814230-1-anshulusr@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] dt-bindings: iio: light: add ltr390 | expand |
On 09/11/2023 10:04, Anshul Dalal wrote: > Add binding for Lite-On LTR390 which is an Ambient/UV light sensor that > communicates over i2c with an address of 0x53. > > Datasheet: > https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > + interrupts: > + maxItems: 1 > + description: | > + Level interrupt pin with open drain output. > + The sensor pulls this pin low when the measured reading is greater than > + some configured threshold. > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@53 { > + compatible = "liteon,ltr390"; > + reg = <0x53>; Please extend the example to be complete - interrupts and vdd-supply. Best regards, Krzysztof
Hello Krzysztof, On 11/9/23 15:57, Krzysztof Kozlowski wrote: > On 09/11/2023 10:04, Anshul Dalal wrote: >> Add binding for Lite-On LTR390 which is an Ambient/UV light sensor that >> communicates over i2c with an address of 0x53. >> >> Datasheet: >> https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf >> >> Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > > >> + interrupts: >> + maxItems: 1 >> + description: | >> + Level interrupt pin with open drain output. >> + The sensor pulls this pin low when the measured reading is greater than >> + some configured threshold. >> + >> + vdd-supply: true >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + light-sensor@53 { >> + compatible = "liteon,ltr390"; >> + reg = <0x53>; > > Please extend the example to be complete - interrupts and vdd-supply. Could the following be used as a suitable example. #include <dt-bindings/interrupt-controller/irq.h> i2c { #address-cells = <1>; #size-cells = <0>; light-sensor@53 { compatible = "liteon,ltr390"; reg = <0x53>; interrupts = <18 IRQ_TYPE_EDGE_FALLING>; vdd-supply = <&vdd_regulator>; }; }; Thanks for the review. Best regards, Anshul
On 09/11/2023 11:35, Anshul Dalal wrote: >>> +examples: >>> + - | >>> + i2c { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + light-sensor@53 { >>> + compatible = "liteon,ltr390"; >>> + reg = <0x53>; >> >> Please extend the example to be complete - interrupts and vdd-supply. > > Could the following be used as a suitable example. > Yes Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml new file mode 100644 index 000000000000..90c20076b6c5 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/liteon,ltr390.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lite-On LTR390 ALS and UV Sensor + +description: | + The Lite-On LTR390 is an ALS (Ambient Light Sensor) and a UV sensor in a + single package with i2c address of 0x53. + + Datasheet: https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf + +maintainers: + - Anshul Dalal <anshulusr@gmail.com> + +properties: + compatible: + enum: + - liteon,ltr390 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + description: | + Level interrupt pin with open drain output. + The sensor pulls this pin low when the measured reading is greater than + some configured threshold. + + vdd-supply: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@53 { + compatible = "liteon,ltr390"; + reg = <0x53>; + }; + };
Add binding for Lite-On LTR390 which is an Ambient/UV light sensor that communicates over i2c with an address of 0x53. Datasheet: https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf Signed-off-by: Anshul Dalal <anshulusr@gmail.com> --- .../bindings/iio/light/liteon,ltr390.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/liteon,ltr390.yaml