[v3,2/2] dt-bindings: iio: hmc425a: add entry for ADRF5740 Attenuator

Commit Message

Ana-Maria Cusco Nov. 13, 2023, 10:25 a.m. UTC

From: Ana-Maria Cusco <[e-mail]>

The ADRF5740 is a silicon, 4-bit digital attenuator with 22 dB
attenuation control range in 2 dB steps.

Signed-off-by: Ana-Maria Cusco <[e-mail]>
---
 .../devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml       | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Conor Dooley Nov. 13, 2023, 1:40 p.m. UTC | #1

On Mon, Nov 13, 2023 at 12:25:35PM +0200, Ana-Maria Cusco wrote:
> From: Ana-Maria Cusco <[e-mail]>
> 
> The ADRF5740 is a silicon, 4-bit digital attenuator with 22 dB
> attenuation control range in 2 dB steps.
> 
> Signed-off-by: Ana-Maria Cusco <[e-mail]>

Acked-by: Conor Dooley <[e-mail]>

Thanks,
Conor.

Conor Dooley Nov. 13, 2023, 1:41 p.m. UTC | #2

On Mon, Nov 13, 2023 at 01:40:40PM +0000, Conor Dooley wrote:
> On Mon, Nov 13, 2023 at 12:25:35PM +0200, Ana-Maria Cusco wrote:
> > From: Ana-Maria Cusco <[e-mail]>
> > 
> > The ADRF5740 is a silicon, 4-bit digital attenuator with 22 dB
> > attenuation control range in 2 dB steps.
> > 
> > Signed-off-by: Ana-Maria Cusco <[e-mail]>
> 
> Acked-by: Conor Dooley <[e-mail]>

One thing though, the bindings patch should come before the driver patch
in your series.

Thanks,
conor.

Jonathan Cameron Nov. 26, 2023, 4:39 p.m. UTC | #3

On Mon, 13 Nov 2023 13:41:27 +0000
Conor Dooley <[e-mail]> wrote:

> On Mon, Nov 13, 2023 at 01:40:40PM +0000, Conor Dooley wrote:
> > On Mon, Nov 13, 2023 at 12:25:35PM +0200, Ana-Maria Cusco wrote:  
> > > From: Ana-Maria Cusco <[e-mail]>
> > > 
> > > The ADRF5740 is a silicon, 4-bit digital attenuator with 22 dB
> > > attenuation control range in 2 dB steps.
> > > 
> > > Signed-off-by: Ana-Maria Cusco <[e-mail]>  
> > 
> > Acked-by: Conor Dooley <[e-mail]>  
> 
> One thing though, the bindings patch should come before the driver patch
> in your series.
Flipped order whilst applying.

Applied to the togreg branch of iio.git an pushed out initially as
testing for 0-day to poke at it and see if it can find anythign we missed.

Trivial thing but Ana-Maria, I'd prefer a cover letter even on a short series
like this. It provides a place for general comments / discussion / tags to be
applied and it gives it a pretty name in patchwork.

Jonathan


> 
> Thanks,
> conor.

Conor Dooley Nov. 27, 2023, 5:48 p.m. UTC | #4

On Sun, Nov 26, 2023 at 04:39:22PM +0000, Jonathan Cameron wrote:

> Trivial thing but Ana-Maria, I'd prefer a cover letter even on a short series
> like this. It provides a place for general comments / discussion / tags to be
> applied and it gives it a pretty name in patchwork.

It also helps patchwork detect when things are a later revision and mark
the old ones as superseded, which is rather nice :)

Patch

diff --git a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
index 2ee6080deac7..67de9d4e3a1d 100644
--- a/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
+++ b/Documentation/devicetree/bindings/iio/amplifiers/adi,hmc425a.yaml
@@ -12,6 +12,9 @@  maintainers:
 description: |
   Digital Step Attenuator IIO devices with gpio interface.
   Offer various frequency and attenuation ranges.
+  ADRF5750 2 dB LSB, 4-Bit, Silicon Digital Attenuator, 10 MHz to 60 GHz
+    https://www.analog.com/media/en/technical-documentation/data-sheets/adrf5740.pdf
+
   HMC425A 0.5 dB LSB GaAs MMIC 6-BIT DIGITAL POSITIVE CONTROL ATTENUATOR, 2.2 - 8.0 GHz
     https://www.analog.com/media/en/technical-documentation/data-sheets/hmc425A.pdf
 
@@ -22,6 +25,7 @@  description: |
 properties:
   compatible:
     enum:
+      - adi,adrf5740
       - adi,hmc425a
       - adi,hmc540s