Message ID | 20231115125810.1394854-2-anshulusr@gmail.com (mailing list archive) |
---|---|
State | Changes Requested |
Headers | show |
Series | [v2,1/3] dt-bindings: vendor-prefixes: add aosong | expand |
On Wed, Nov 15, 2023 at 06:28:07PM +0530, Anshul Dalal wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > --- > > Changes for v2: > - Removed device from trivial-devices Your $subject still says "trivial-devices" though, so please fix that in your next submission. > - Added standalone binding with vdd-supply property > --- > .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > > diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > new file mode 100644 > index 000000000000..4a0278c6318c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aosong AGS02MA VOC Sensor > + > +description: | > + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > + address of 0x1a. > + > + Datasheet: > + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > + > +maintainers: > + - Anshul Dalal <anshulusr@gmail.com> > + > +properties: > + compatible: > + enum: > + - aosong,ags02ma > + - asair,ags02ma Why do you have two compatibles for the same device? Please document and use only one of these. The aoson website says: "Guangzhou ASAIR Electronic Co., Ltd" so I suspect "asair" is a more apt vendor prefix. Thanks, Conor. > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@1a { > + compatible = "aosong,ags02ma"; > + reg = <0x1a>; > + vdd-supply = <&vdd_regulator>; > + }; > + }; > -- > 2.42.0 >
On 11/15/23 20:08, Conor Dooley wrote: > On Wed, Nov 15, 2023 at 06:28:07PM +0530, Anshul Dalal wrote: >> Add bindings for Aosong AGS02MA TVOC sensor. >> >> The sensor communicates over i2c with the default address 0x1a. >> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. >> >> Datasheet: >> https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf >> Product-Page: >> http://www.aosong.com/m/en/products-33.html >> >> Signed-off-by: Anshul Dalal <anshulusr@gmail.com> >> --- >> >> Changes for v2: >> - Removed device from trivial-devices > > Your $subject still says "trivial-devices" though, so please fix that in > your next submission. > >> - Added standalone binding with vdd-supply property >> --- >> .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml >> new file mode 100644 >> index 000000000000..4a0278c6318c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml >> @@ -0,0 +1,48 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Aosong AGS02MA VOC Sensor >> + >> +description: | >> + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default >> + address of 0x1a. >> + >> + Datasheet: >> + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf >> + >> +maintainers: >> + - Anshul Dalal <anshulusr@gmail.com> >> + >> +properties: >> + compatible: >> + enum: >> + - aosong,ags02ma >> + - asair,ags02ma > > Why do you have two compatibles for the same device? Please document and > use only one of these. The aoson website says: > "Guangzhou ASAIR Electronic Co., Ltd" I'm sorry but I couldn't find any reference to such name on http://www.aosong.com/en/ In the contact page (http://www.aosong.com/en/article-34.html), I could only find references to "Guangzhou Aosong Electronic Co., Ltd." > so I suspect "asair" is a more apt vendor prefix. > Asair is the brand name under which Guangzhou Aosong Electronics sells their products [0]. After a prior discussion with Krzysztof [1], I thought it would be the best to go with Aosong instead. The rationale being since a vendor can only have a single prefix, if Aosong were to sell some new product under the name Aosong, it would then have to have the same vendor-prefix as other products under the Asair brand. [0]: https://www.linkedin.com/company/asairsensor/ [1]: https://lore.kernel.org/lkml/1f62ab04-1679-44b1-b95e-e3954afbfa88@linaro.org/ Best regards, Anshul
On Wed, Nov 15, 2023 at 09:29:20PM +0530, Anshul Dalal wrote: > On 11/15/23 20:08, Conor Dooley wrote: > > On Wed, Nov 15, 2023 at 06:28:07PM +0530, Anshul Dalal wrote: > >> Add bindings for Aosong AGS02MA TVOC sensor. > >> > >> The sensor communicates over i2c with the default address 0x1a. > >> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > >> > >> Datasheet: > >> https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > >> Product-Page: > >> http://www.aosong.com/m/en/products-33.html > >> > >> Signed-off-by: Anshul Dalal <anshulusr@gmail.com> > >> --- > >> > >> Changes for v2: > >> - Removed device from trivial-devices > > > > Your $subject still says "trivial-devices" though, so please fix that in > > your next submission. > > > >> - Added standalone binding with vdd-supply property > >> --- > >> .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++ > >> 1 file changed, 48 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > >> new file mode 100644 > >> index 000000000000..4a0278c6318c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml > >> @@ -0,0 +1,48 @@ > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Aosong AGS02MA VOC Sensor > >> + > >> +description: | > >> + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > >> + address of 0x1a. > >> + > >> + Datasheet: > >> + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > >> + > >> +maintainers: > >> + - Anshul Dalal <anshulusr@gmail.com> > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - aosong,ags02ma > >> + - asair,ags02ma > > > > Why do you have two compatibles for the same device? Please document and > > use only one of these. The aoson website says: > > "Guangzhou ASAIR Electronic Co., Ltd" > > I'm sorry but I couldn't find any reference to such name on > http://www.aosong.com/en/ > In the contact page (http://www.aosong.com/en/article-34.html), > I could only find references to "Guangzhou Aosong Electronic Co., Ltd." On the page you linked in your original submission: www.aosong.com/m/en/products-33.html (scroll down) > > so I suspect "asair" is a more apt vendor prefix. > > > > Asair is the brand name under which Guangzhou Aosong Electronics sells > their products [0]. After a prior discussion with Krzysztof [1], I > thought it would be the best to go with Aosong instead. > > The rationale being since a vendor can only have a single prefix, if > Aosong were to sell some new product under the name Aosong, it would > then have to have the same vendor-prefix as other products under the > Asair brand. Go with Aosong then, sure. But please drop the "asair" prefixed compatible from your binding. Cheers, Conor,
diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml new file mode 100644 index 000000000000..4a0278c6318c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aosong AGS02MA VOC Sensor + +description: | + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default + address of 0x1a. + + Datasheet: + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf + +maintainers: + - Anshul Dalal <anshulusr@gmail.com> + +properties: + compatible: + enum: + - aosong,ags02ma + - asair,ags02ma + + reg: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@1a { + compatible = "aosong,ags02ma"; + reg = <0x1a>; + vdd-supply = <&vdd_regulator>; + }; + };
Add bindings for Aosong AGS02MA TVOC sensor. The sensor communicates over i2c with the default address 0x1a. TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. Datasheet: https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf Product-Page: http://www.aosong.com/m/en/products-33.html Signed-off-by: Anshul Dalal <anshulusr@gmail.com> --- Changes for v2: - Removed device from trivial-devices - Added standalone binding with vdd-supply property --- .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml