| Message ID | 20231121095800.2180870-2-anshulusr@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v3,1/3] dt-bindings: vendor-prefixes: add aosong | expand |
On 21/11/2023 10:57, Anshul Dalal wrote: > Add bindings for Aosong AGS02MA TVOC sensor. > > The sensor communicates over i2c with the default address 0x1a. > TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. > > Datasheet: > https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > Product-Page: > http://www.aosong.com/m/en/products-33.html > > +--- > +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aosong AGS02MA VOC Sensor > + > +description: | > + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default > + address of 0x1a. What does it measure? Light? > + > + Datasheet: > + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf > + > +maintainers: > + - Anshul Dalal <anshulusr@gmail.com> > + > +properties: > + compatible: > + enum: > + - aosong,ags02ma > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@1a { You called it chemical, so why this is here light-sensor? > + compatible = "aosong,ags02ma"; > + reg = <0x1a>; > + vdd-supply = <&vdd_regulator>; > + }; > + }; Best regards, Krzysztof
On 11/21/23 15:33, Krzysztof Kozlowski wrote: > On 21/11/2023 10:57, Anshul Dalal wrote: >> Add bindings for Aosong AGS02MA TVOC sensor. >> >> The sensor communicates over i2c with the default address 0x1a. >> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. >> >> Datasheet: >> https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf >> Product-Page: >> http://www.aosong.com/m/en/products-33.html >> > > >> +--- >> +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Aosong AGS02MA VOC Sensor >> [..] >> +examples: >> + - | >> + #include <dt-bindings/interrupt-controller/irq.h> >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + light-sensor@1a { > > > You called it chemical, so why this is here light-sensor? I was working on a binding for a light sensor in parallel at that time, I probably forgot to change this when copying the example from the light sensor. Would be replaced by "voc-sensor" in the next revision, apologies for any inconvenience. Thanks for the review. Best Regards, Anshul
diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml new file mode 100644 index 000000000000..38ba3614ae8a --- /dev/null +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aosong AGS02MA VOC Sensor + +description: | + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default + address of 0x1a. + + Datasheet: + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf + +maintainers: + - Anshul Dalal <anshulusr@gmail.com> + +properties: + compatible: + enum: + - aosong,ags02ma + + reg: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@1a { + compatible = "aosong,ags02ma"; + reg = <0x1a>; + vdd-supply = <&vdd_regulator>; + }; + };
Add bindings for Aosong AGS02MA TVOC sensor. The sensor communicates over i2c with the default address 0x1a. TVOC values can be read in the units of ppb and ug/m^3 at register 0x00. Datasheet: https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf Product-Page: http://www.aosong.com/m/en/products-33.html Signed-off-by: Anshul Dalal <anshulusr@gmail.com> --- Changes for v3: - Fixed commit message - Removed "asair,ags02ma" compatible v2: https://lore.kernel.org/lkml/20231115125810.1394854-2-anshulusr@gmail.com/ Changes for v2: - Removed device from trivial-devices - Added standalone binding with vdd-supply property v1: https://lore.kernel.org/lkml/20231107173100.62715-2-anshulusr@gmail.com/ --- .../bindings/iio/chemical/aosong,ags02ma.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml