[v2,2/8] dt-bindings: adc: axi-adc: deprecate 'adi,adc-dev'

Commit Message

Nuno Sa via B4 Relay Dec. 8, 2023, 3:14 p.m. UTC

From: Nuno Sa <[e-mail]>

'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
also remove it from being required.

Signed-off-by: Nuno Sa <[e-mail]>
---
 Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Krzysztof Kozlowski Dec. 8, 2023, 5:39 p.m. UTC | #1

On 08/12/2023 16:14, Nuno Sa via B4 Relay wrote:
> From: Nuno Sa <[e-mail]>
> 
> 'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
> also remove it from being required.

Why did it become suddenly deprecated? Unfortunately the commit msg does
not tell me more, except copying the code...

If this is result of previous patch, then squash it.

Best regards,
Krzysztof

Nuno Sá Dec. 9, 2023, 2:40 p.m. UTC | #2

On Fri, 2023-12-08 at 18:39 +0100, Krzysztof Kozlowski wrote:
> On 08/12/2023 16:14, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <[e-mail]>
> > 
> > 'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
> > also remove it from being required.
> 
> Why did it become suddenly deprecated? Unfortunately the commit msg does
> not tell me more, except copying the code...
> 
> If this is result of previous patch, then squash it.
> 

This property will be deprecated by the generic property mentioned in the cover
(basically the property in patch 1).

I'll improve the commit message on why it's being deprecated. It has a lot to do with
the changes in the drivers and how we want to start handling these HW arrangements.
I'll try to explain it in a way that makes sense from a bindings point of view.

Thanks!
- Nuno Sá

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
index 9996dd93f84b..835b40063343 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
@@ -39,12 +39,12 @@  properties:
     $ref: /schemas/types.yaml#/definitions/phandle
     description:
       A reference to a the actual ADC to which this FPGA ADC interfaces to.
+    deprecated: true
 
 required:
   - compatible
   - dmas
   - reg
-  - adi,adc-dev
 
 additionalProperties: false
 
@@ -55,7 +55,5 @@  examples:
         reg = <0x44a00000 0x10000>;
         dmas = <&rx_dma 0>;
         dma-names = "rx";
-
-        adi,adc-dev = <&spi_adc>;
     };
 ...