| Message ID | 20231220-iio-backend-v4-4-998e9148b692@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: add new backend framework | expand |
On Wed, 20 Dec 2023 16:34:07 +0100, Nuno Sa wrote: > From: Olivier Moysan <olivier.moysan@foss.st.com> > > Add support for creating device links out of more DT properties. > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > --- > drivers/of/property.c | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Wed, Dec 20, 2023 at 9:32 AM Nuno Sa <nuno.sa@analog.com> wrote: > > From: Olivier Moysan <olivier.moysan@foss.st.com> > > Add support for creating device links out of more DT properties. > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > --- > drivers/of/property.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index afdaefbd03f6..a4835447759f 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -1244,6 +1244,7 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") > DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells") > DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells") > DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells") > +DEFINE_SIMPLE_PROP(io_backends, "io-backends", NULL) In v3 it was agreed that adding #io-backend-cells right way seemed like a good idea. Do we need to include that here? > DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL) > DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells") > DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells") > @@ -1334,6 +1335,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { > { .parse_prop = parse_iommu_maps, .optional = true, }, > { .parse_prop = parse_mboxes, }, > { .parse_prop = parse_io_channels, }, > + { .parse_prop = parse_io_backends, }, > { .parse_prop = parse_interrupt_parent, }, > { .parse_prop = parse_dmas, .optional = true, }, > { .parse_prop = parse_power_domains, }, > > -- > 2.43.0 > >
On Wed, 2024-01-03 at 15:39 -0600, David Lechner wrote: > On Wed, Dec 20, 2023 at 9:32 AM Nuno Sa <nuno.sa@analog.com> wrote: > > > > From: Olivier Moysan <olivier.moysan@foss.st.com> > > > > Add support for creating device links out of more DT properties. > > > > Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com> > > Signed-off-by: Nuno Sa <nuno.sa@analog.com> > > --- > > drivers/of/property.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/of/property.c b/drivers/of/property.c > > index afdaefbd03f6..a4835447759f 100644 > > --- a/drivers/of/property.c > > +++ b/drivers/of/property.c > > @@ -1244,6 +1244,7 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", > > "#interconnect-cells") > > DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells") > > DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells") > > DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells") > > +DEFINE_SIMPLE_PROP(io_backends, "io-backends", NULL) > > In v3 it was agreed that adding #io-backend-cells right way seemed > like a good idea. Do we need to include that here? > Yeah that's something I forgot and should do in v5. Should also update the core code and the backend bindings (axi-adc) to have it (one of Rob's points in having the #cells was to easily identify backends - providers). Thanks for spotting this! - Nuno Sá >
diff --git a/drivers/of/property.c b/drivers/of/property.c index afdaefbd03f6..a4835447759f 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1244,6 +1244,7 @@ DEFINE_SIMPLE_PROP(interconnects, "interconnects", "#interconnect-cells") DEFINE_SIMPLE_PROP(iommus, "iommus", "#iommu-cells") DEFINE_SIMPLE_PROP(mboxes, "mboxes", "#mbox-cells") DEFINE_SIMPLE_PROP(io_channels, "io-channel", "#io-channel-cells") +DEFINE_SIMPLE_PROP(io_backends, "io-backends", NULL) DEFINE_SIMPLE_PROP(interrupt_parent, "interrupt-parent", NULL) DEFINE_SIMPLE_PROP(dmas, "dmas", "#dma-cells") DEFINE_SIMPLE_PROP(power_domains, "power-domains", "#power-domain-cells") @@ -1334,6 +1335,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_iommu_maps, .optional = true, }, { .parse_prop = parse_mboxes, }, { .parse_prop = parse_io_channels, }, + { .parse_prop = parse_io_backends, }, { .parse_prop = parse_interrupt_parent, }, { .parse_prop = parse_dmas, .optional = true, }, { .parse_prop = parse_power_domains, },