| Message ID | 20231220184753.6472-1-semen.protsenko@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: pressure: bmp280: Add missing bmp085 to SPI id table | expand |
On Wed, Dec 20, 2023 at 12:47:53PM -0600, Sam Protsenko wrote: > "bmp085" is missing in bmp280_spi_id[] table, which leads to the next > warning in dmesg: > > SPI driver bmp280 has no spi_device_id for bosch,bmp085 > > Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in > bmp280_of_spi_match[] table to fix the above warning. Good catch! Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko <semen.protsenko@linaro.org> wrote: > "bmp085" is missing in bmp280_spi_id[] table, which leads to the next > warning in dmesg: > > SPI driver bmp280 has no spi_device_id for bosch,bmp085 > > Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in > bmp280_of_spi_match[] table to fix the above warning. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver") Right! Thanks for fixing this Sam! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Wed, 20 Dec 2023 20:07:57 +0100 Linus Walleij <linus.walleij@linaro.org> wrote: > On Wed, Dec 20, 2023 at 7:47 PM Sam Protsenko > <semen.protsenko@linaro.org> wrote: > > > "bmp085" is missing in bmp280_spi_id[] table, which leads to the next > > warning in dmesg: > > > > SPI driver bmp280 has no spi_device_id for bosch,bmp085 > > > > Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in > > bmp280_of_spi_match[] table to fix the above warning. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver") > > Right! Thanks for fixing this Sam! > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, J > Yours, > Linus Walleij
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c index 433d6fac83c4..e8a5fed07e88 100644 --- a/drivers/iio/pressure/bmp280-spi.c +++ b/drivers/iio/pressure/bmp280-spi.c @@ -87,6 +87,7 @@ static const struct of_device_id bmp280_of_spi_match[] = { MODULE_DEVICE_TABLE(of, bmp280_of_spi_match); static const struct spi_device_id bmp280_spi_id[] = { + { "bmp085", (kernel_ulong_t)&bmp180_chip_info }, { "bmp180", (kernel_ulong_t)&bmp180_chip_info }, { "bmp181", (kernel_ulong_t)&bmp180_chip_info }, { "bmp280", (kernel_ulong_t)&bmp280_chip_info },
"bmp085" is missing in bmp280_spi_id[] table, which leads to the next warning in dmesg: SPI driver bmp280 has no spi_device_id for bosch,bmp085 Add "bmp085" to bmp280_spi_id[] by mimicking its existing description in bmp280_of_spi_match[] table to fix the above warning. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Fixes: b26b4e91700f ("iio: pressure: bmp280: add SPI interface driver") --- drivers/iio/pressure/bmp280-spi.c | 1 + 1 file changed, 1 insertion(+)