| Message ID | 20240204180536.30617-2-jesusmgh@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] Add 10EC5280 to bmi160_i2c ACPI IDs to allow binding on some devices | expand |
On Sun, 4 Feb 2024 19:05:37 +0100 Jesus Gonzalez <jesusmgh@gmail.com> wrote: > "10EC5280" is used by several manufacturers like Lenovo, GPD, or AYA (and > probably others) in their ACPI table as the ID for the bmi160 IMU. This > means the bmi160_i2c driver won't bind to it, and the IMU is unavailable > to the user. Manufacturers have been approached on several occasions to > try getting a BIOS with a fixed ID, mostly without actual positive > results, and since affected devices are already a few years old, this is > not expected to change. This patch enables using the bmi160_i2c driver for > the bmi160 IMU on these devices. > > Signed-off-by: Jesus Gonzalez <jesusmgh@gmail.com> Make sure to include v2 in the patch title. git format-patch -v2 ... + as per other reply, I'd like to see more info in here including the DSDT blob. Thanks, Jonathan > --- > drivers/iio/imu/bmi160/bmi160_spi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/iio/imu/bmi160/bmi160_spi.c b/drivers/iio/imu/bmi160/bmi160_spi.c > index 8b573ea99af2..0df961a129bb 100644 > --- a/drivers/iio/imu/bmi160/bmi160_spi.c > +++ b/drivers/iio/imu/bmi160/bmi160_spi.c > @@ -41,6 +41,14 @@ MODULE_DEVICE_TABLE(spi, bmi160_spi_id); > > static const struct acpi_device_id bmi160_acpi_match[] = { > {"BMI0160", 0}, > + /* FIRMWARE BUG WORKAROUND > + * Some manufacturers like GPD, Lenovo or Aya used the incorrect > + * ID "10EC5280" for bmi160 in their DSDT. A fixed firmware is not > + * available as of Feb 2024 after trying to work with OEMs, and > + * this is not expected to change anymore since at least some of > + * the affected devices are from 2021/2022. > + */ > + {"10EC5280", 0}, > { }, > }; > MODULE_DEVICE_TABLE(acpi, bmi160_acpi_match);
diff --git a/drivers/iio/imu/bmi160/bmi160_spi.c b/drivers/iio/imu/bmi160/bmi160_spi.c index 8b573ea99af2..0df961a129bb 100644 --- a/drivers/iio/imu/bmi160/bmi160_spi.c +++ b/drivers/iio/imu/bmi160/bmi160_spi.c @@ -41,6 +41,14 @@ MODULE_DEVICE_TABLE(spi, bmi160_spi_id); static const struct acpi_device_id bmi160_acpi_match[] = { {"BMI0160", 0}, + /* FIRMWARE BUG WORKAROUND + * Some manufacturers like GPD, Lenovo or Aya used the incorrect + * ID "10EC5280" for bmi160 in their DSDT. A fixed firmware is not + * available as of Feb 2024 after trying to work with OEMs, and + * this is not expected to change anymore since at least some of + * the affected devices are from 2021/2022. + */ + {"10EC5280", 0}, { }, }; MODULE_DEVICE_TABLE(acpi, bmi160_acpi_match);
"10EC5280" is used by several manufacturers like Lenovo, GPD, or AYA (and probably others) in their ACPI table as the ID for the bmi160 IMU. This means the bmi160_i2c driver won't bind to it, and the IMU is unavailable to the user. Manufacturers have been approached on several occasions to try getting a BIOS with a fixed ID, mostly without actual positive results, and since affected devices are already a few years old, this is not expected to change. This patch enables using the bmi160_i2c driver for the bmi160 IMU on these devices. Signed-off-by: Jesus Gonzalez <jesusmgh@gmail.com> --- drivers/iio/imu/bmi160/bmi160_spi.c | 8 ++++++++ 1 file changed, 8 insertions(+)