| Message ID | 20240220184125.32602-2-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/2] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI support | expand |
On Tue, Feb 20, 2024 at 07:41:25PM +0100, Vasileios Amoiridis wrote: > Alphabetical sorting and separation of headers for the BMPxxx > SPI driver. ... > -#include <linux/module.h> > -#include <linux/spi/spi.h> > +#include <linux/bits.h> > #include <linux/err.h> > +#include <linux/module.h> > #include <linux/regmap.h> > -#include <linux/bits.h> That's what I meant. Please do not add it into the wrong place to begin with. > +#include <linux/spi/spi.h>
On Tue, 20 Feb 2024 21:56:15 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Tue, Feb 20, 2024 at 07:41:25PM +0100, Vasileios Amoiridis wrote: > > Alphabetical sorting and separation of headers for the BMPxxx > > SPI driver. > > ... > > > -#include <linux/module.h> > > -#include <linux/spi/spi.h> > > +#include <linux/bits.h> > > #include <linux/err.h> > > +#include <linux/module.h> > > #include <linux/regmap.h> > > > -#include <linux/bits.h> > > That's what I meant. Please do not add it into the wrong place to begin with. > > > +#include <linux/spi/spi.h> > This isn't going be something I rush in with the fix, so plenty of time to revisit this next cycle. Thanks, Jonathan
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c index 1972014dca93..3458806f11fb 100644 --- a/drivers/iio/pressure/bmp280-spi.c +++ b/drivers/iio/pressure/bmp280-spi.c @@ -4,11 +4,12 @@ * * Inspired by the older BMP085 driver drivers/misc/bmp085-spi.c */ -#include <linux/module.h> -#include <linux/spi/spi.h> +#include <linux/bits.h> #include <linux/err.h> +#include <linux/module.h> #include <linux/regmap.h> -#include <linux/bits.h> + +#include <linux/spi/spi.h> #include "bmp280.h"
Alphabetical sorting and separation of headers for the BMPxxx SPI driver. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- drivers/iio/pressure/bmp280-spi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)