| Message ID | 20240220224329.53729-1-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [1/2] drivers: iio: pressure: Sort headers of BMPxxx SPI driver | expand |
On Tue, Feb 20, 2024 at 11:43:28PM +0100, Vasileios Amoiridis wrote: > Alphabetical sorting and separation of headers for the BMPxxx > SPI driver. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Tue, 2024-02-20 at 23:43 +0100, Vasileios Amoiridis wrote: > Alphabetical sorting and separation of headers for the BMPxxx > SPI driver. > LGTM, so: Acked-by: Angel Iglesias <ang.iglesiasg@gmail.com> Kind regards, Angel
On Tue, 20 Feb 2024 23:43:28 +0100 Vasileios Amoiridis <vassilisamir@gmail.com> wrote: > Alphabetical sorting and separation of headers for the BMPxxx > SPI driver. > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> Hi Vasileios, No. This ends up as a dependency of the fix which will want backporting. This would make it a non minimal change. As such the reordering comes after the other patch (and not until it is upstream). All that needed to happen was bits.h being first of the includes in the fixes patch so that a sort later was minimal. Doing that had no impact on the complexity of the fix to backport so was just good code hygiene in that would simplify the resort to follow. Anyhow, dropping this for now. Please send an update version next cycle once the fix is upstream Thanks, Jonathan > --- > drivers/iio/pressure/bmp280-spi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c > index e8a5fed07e88..fd7ec6a5bca3 100644 > --- a/drivers/iio/pressure/bmp280-spi.c > +++ b/drivers/iio/pressure/bmp280-spi.c > @@ -4,11 +4,12 @@ > * > * Inspired by the older BMP085 driver drivers/misc/bmp085-spi.c > */ > -#include <linux/module.h> > -#include <linux/spi/spi.h> > #include <linux/err.h> > +#include <linux/module.h> > #include <linux/regmap.h> > > +#include <linux/spi/spi.h> > + > #include "bmp280.h" > > static int bmp280_regmap_spi_write(void *context, const void *data,
On Sat, Feb 24, 2024 at 06:04:12PM +0000, Jonathan Cameron wrote: > On Tue, 20 Feb 2024 23:43:28 +0100 > Vasileios Amoiridis <vassilisamir@gmail.com> wrote: > > > Alphabetical sorting and separation of headers for the BMPxxx > > SPI driver. > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > Hi Vasileios, > > No. This ends up as a dependency of the fix which will want backporting. > This would make it a non minimal change. As such the reordering comes > after the other patch (and not until it is upstream). > > All that needed to happen was bits.h being first of the includes in the > fixes patch so that a sort later was minimal. Doing that had no impact > on the complexity of the fix to backport so was just good code hygiene > in that would simplify the resort to follow. > > Anyhow, dropping this for now. Please send an update version > next cycle once the fix is upstream > > Thanks, > > Jonathan > Hi Jonathan, Thank you very much again for the comments and I am sorry for not versioning them properly, it won't happen again. I also understand what you mean in the previous message and I will definitely submit it again, first thing after the changes are upstreamed. Thanks, Vasileios > > --- > > drivers/iio/pressure/bmp280-spi.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c > > index e8a5fed07e88..fd7ec6a5bca3 100644 > > --- a/drivers/iio/pressure/bmp280-spi.c > > +++ b/drivers/iio/pressure/bmp280-spi.c > > @@ -4,11 +4,12 @@ > > * > > * Inspired by the older BMP085 driver drivers/misc/bmp085-spi.c > > */ > > -#include <linux/module.h> > > -#include <linux/spi/spi.h> > > #include <linux/err.h> > > +#include <linux/module.h> > > #include <linux/regmap.h> > > > > +#include <linux/spi/spi.h> > > + > > #include "bmp280.h" > > > > static int bmp280_regmap_spi_write(void *context, const void *data, >
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c index e8a5fed07e88..fd7ec6a5bca3 100644 --- a/drivers/iio/pressure/bmp280-spi.c +++ b/drivers/iio/pressure/bmp280-spi.c @@ -4,11 +4,12 @@ * * Inspired by the older BMP085 driver drivers/misc/bmp085-spi.c */ -#include <linux/module.h> -#include <linux/spi/spi.h> #include <linux/err.h> +#include <linux/module.h> #include <linux/regmap.h> +#include <linux/spi/spi.h> + #include "bmp280.h" static int bmp280_regmap_spi_write(void *context, const void *data,
Alphabetical sorting and separation of headers for the BMPxxx SPI driver. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- drivers/iio/pressure/bmp280-spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)