| Message ID | 20240329151535.712827-3-inv.git-commit@tdk.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: imu: inv_icm42600: add support of ICM-42688-P | expand |
On Fri, 29 Mar 2024 15:49:26 +0000 Conor Dooley <conor@kernel.org> wrote: > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > Add bindings for ICM-42688-P chip. > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > My initial thought was that you're missing a sign-off, but is > "inv.git-commit@tdk.com" some system you have to bypass corporate email > garbage? Common enough setup, as long as the From: line matches the sign-off, git will ignore the email address used to send it when the patch is applied. > > > --- > > .../devicetree/bindings/iio/imu/invensense,icm42600.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > index 7cd05bcbee31..152aec8d82ff 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml > > @@ -31,6 +31,7 @@ properties: > > - invensense,icm42602 > > - invensense,icm42605 > > - invensense,icm42622 > > + - invensense,icm42688 > > Can you add this in alphanumerical order please? > > Also, this patch should be the first in the series. Agreed on both, otherwise this series LGTM Jonathan > > Thanks, > Conor. > > > - invensense,icm42631 > > > > reg: > > -- > > 2.34.1 > >
On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote: > On Fri, 29 Mar 2024 15:49:26 +0000 > Conor Dooley <conor@kernel.org> wrote: > > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > Add bindings for ICM-42688-P chip. > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > My initial thought was that you're missing a sign-off, but is > > "inv.git-commit@tdk.com" some system you have to bypass corporate email > > garbage? > > Common enough setup, as long as the From: line matches the sign-off, git will > ignore the email address used to send it when the patch is applied. Yeah, I know how it works, I do it all the time. Even found, or rather caused, a b4 bug where it would use the sending email in the eventual commit rather than the author: https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/ I'm just double checking that there's not a missing signoff. When I've seen these corp-email-bypass accounts before people set a proper "from" in git send-email so there's a name in it: "A Dev <inv.git-commit@tdk.com>"
On Mon, 1 Apr 2024 12:04:55 +0100 Conor Dooley <conor@kernel.org> wrote: > On Sat, Mar 30, 2024 at 04:10:12PM +0000, Jonathan Cameron wrote: > > On Fri, 29 Mar 2024 15:49:26 +0000 > > Conor Dooley <conor@kernel.org> wrote: > > > > > On Fri, Mar 29, 2024 at 03:15:35PM +0000, inv.git-commit@tdk.com wrote: > > > > From: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > > > Add bindings for ICM-42688-P chip. > > > > > > > > Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> > > > > > > My initial thought was that you're missing a sign-off, but is > > > "inv.git-commit@tdk.com" some system you have to bypass corporate email > > > garbage? > > > > Common enough setup, as long as the From: line matches the sign-off, git will > > ignore the email address used to send it when the patch is applied. > > Yeah, I know how it works, I do it all the time. Even found, or rather > caused, a b4 bug where it would use the sending email in the eventual > commit rather than the author: > https://lore.kernel.org/tools/20230310192652.ymac3w2lucfdf34p@meerkat.local/ > > I'm just double checking that there's not a missing signoff. When I've > seen these corp-email-bypass accounts before people set a proper "from" > in git send-email so there's a name in it: "A Dev <inv.git-commit@tdk.com>" > Ah. Got it now :) I guess it depends on how their weird setup wires everything up! Jonathan
diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml index 7cd05bcbee31..152aec8d82ff 100644 --- a/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +++ b/Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml @@ -31,6 +31,7 @@ properties: - invensense,icm42602 - invensense,icm42605 - invensense,icm42622 + - invensense,icm42688 - invensense,icm42631 reg: