diff mbox series

[v3,2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

Message ID 20240527-veml6040-v3-2-6f3bbfd42960@sentec.com (mailing list archive)
State Changes Requested
Headers show
Series Add driver for Vishay VEML6040 | expand

Commit Message

Arthur Becker via B4 Relay May 27, 2024, 3:12 p.m. UTC 
From: Arthur Becker <arthur.becker@sentec.com>

Device tree bindings for the vishay VEML6040 RGBW light sensor iio
driver

Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
---
V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
along with v2 of the driver but not in a set)
---
 .../bindings/iio/light/vishay,veml6040.yaml        | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)

Comments

Conor Dooley May 27, 2024, 4:30 p.m. UTC | #1 
On Mon, May 27, 2024 at 05:12:09PM +0200, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <arthur.becker@sentec.com>
> 
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
> 
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
Krzysztof Kozlowski May 27, 2024, 4:31 p.m. UTC | #2 
On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> From: Arthur Becker <arthur.becker@sentec.com>
> 
> Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> driver
> 
> Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> ---
> V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> along with v2 of the driver but not in a set)

It's basically the same as veml6075, so should be put there...

Eh,

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Arthur Becker May 28, 2024, 7:15 a.m. UTC | #3 
Thanks for the Review!

Cheers,
Arthur
Arthur Becker May 28, 2024, 7:23 a.m. UTC | #4 
Thanks for the Review!
Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
I'll modify that the next time I make adjustments to the driver.

Kind regards,
Arthur
Jonathan Cameron May 28, 2024, 10:05 a.m. UTC | #5 
On Tue, 28 May 2024 07:23:03 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

It's absolutely fine to have shared bindings even if the
drivers (because of different register interface etc) are completely
separate.  It's a good way to keep bindings aligned between
similar devices.

Jonathan

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)  
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 
>
Rob Herring (Arm) May 28, 2024, 2:39 p.m. UTC | #6 
On Tue, May 28, 2024 at 07:23:03AM +0000, Arthur Becker wrote:
> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

Please don't top post, quote replies correctly, and fix your mail setup 
to not add 'EXTERNAL' to the subject.

Rob

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings


> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Arthur Becker May 30, 2024, 9 a.m. UTC | #7 
> From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
> Sent: 28 May 2024 12:05
> To: Arthur Becker
> Cc: Krzysztof Kozlowski; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
>
> On Tue, 28 May 2024 07:23:03 +0000
> Arthur Becker <arthur.becker@sentec.com> wrote:
>
> > Thanks for the Review!
> > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > I'll modify that the next time I make adjustments to the driver.
>
> It's absolutely fine to have shared bindings even if the
> drivers (because of different register interface etc) are completely
> separate.  It's a good way to keep bindings aligned between
> similar devices.
>
> Jonathan

Thanks for the answer, I'll keep that in mind!

Kind regards,
Arthur
Arthur Becker May 30, 2024, 9 a.m. UTC | #8 
>On Tue, May 28, 2024 at 07:23:03AM +0000, Arthur Becker wrote:
>> Thanks for the Review!
>> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
>> I'll modify that the next time I make adjustments to the driver.
>
>Please don't top post, quote replies correctly, and fix your mail setup
>to not add 'EXTERNAL' to the subject.
>
>Rob

Hello Rob,

Sorry about that, I'll keep that in mind in the future. Having to work with oulook can be a bit frustrating.

Kind Regards,
Arthur
Jonathan Cameron June 2, 2024, 1:16 p.m. UTC | #9 
On Tue, 28 May 2024 07:23:03 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> Thanks for the Review!
> Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> I'll modify that the next time I make adjustments to the driver.

Hi Arthur,

If I read the above correctly you are hoping this merges as it stands and
we come back later. If we are going to combine them long term, 
I'd rather we avoided the churn and had a combined DT binding from the start.

Jonathan

> 
> Kind regards,
> Arthur
> 
> ________________________________________
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 27 May 2024 18:31
> To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > From: Arthur Becker <arthur.becker@sentec.com>
> >
> > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > driver
> >
> > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > ---
> > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > along with v2 of the driver but not in a set)  
> 
> It's basically the same as veml6075, so should be put there...
> 
> Eh,
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
>
Arthur Becker June 3, 2024, 8:23 a.m. UTC | #10 
From: Jonathan Cameron <jic23@kernel.org>
Sent: 02 June 2024 15:16
To: Arthur Becker
Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings

> On Tue, 28 May 2024 07:23:03 +0000
> Arthur Becker <arthur.becker@sentec.com> wrote:
> 
> > Thanks for the Review!
> > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > I'll modify that the next time I make adjustments to the driver.
>
> Hi Arthur,
>
> If I read the above correctly you are hoping this merges as it stands and
> we come back later. If we are going to combine them long term,
> I'd rather we avoided the churn and had a combined DT binding from the start.

Hi Jonathan,

I could have phrased that better, what I meant was that I was waiting for the next
feedback on the driver to make the adjustments all at once.
I'll get to it shortly!

Kind Regards,
Arthur

>
> Jonathan
>
> >
> > Kind regards,
> > Arthur
> >
> > ________________________________________
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: 27 May 2024 18:31
> > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> >
> > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:
> > > From: Arthur Becker <arthur.becker@sentec.com>
> > >
> > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > > driver
> > >
> > > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > > ---
> > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > > along with v2 of the driver but not in a set)
> >
> > It's basically the same as veml6075, so should be put there...
> >
> > Eh,
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >
> > Best regards,
> > Krzysztof
> >
Jonathan Cameron June 3, 2024, 8:25 a.m. UTC | #11 
On Mon, 3 Jun 2024 08:23:55 +0000
Arthur Becker <arthur.becker@sentec.com> wrote:

> From: Jonathan Cameron <jic23@kernel.org>
> Sent: 02 June 2024 15:16
> To: Arthur Becker
> Cc: Krzysztof Kozlowski; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley; linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> 
> > On Tue, 28 May 2024 07:23:03 +0000
> > Arthur Becker <arthur.becker@sentec.com> wrote:
> >   
> > > Thanks for the Review!
> > > Right, I wasn't sure if and how to add the veml6040 to the veml6075 dt-binding file.
> > > I'll modify that the next time I make adjustments to the driver.  
> >
> > Hi Arthur,
> >
> > If I read the above correctly you are hoping this merges as it stands and
> > we come back later. If we are going to combine them long term,
> > I'd rather we avoided the churn and had a combined DT binding from the start.  
> 
> Hi Jonathan,
> 
> I could have phrased that better, what I meant was that I was waiting for the next
> feedback on the driver to make the adjustments all at once.
> I'll get to it shortly!

Great :)

Thanks,

Jonathan

> 
> Kind Regards,
> Arthur
> 
> >
> > Jonathan
> >  
> > >
> > > Kind regards,
> > > Arthur
> > >
> > > ________________________________________
> > > From: Krzysztof Kozlowski <krzk@kernel.org>
> > > Sent: 27 May 2024 18:31
> > > To: Arthur Becker; Jonathan Cameron; Lars-Peter Clausen; Rob Herring; Krzysztof Kozlowski; Conor Dooley
> > > Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org; devicetree@vger.kernel.org
> > > Subject: [EXTERNAL]Re: [PATCH v3 2/2] dt-bindings: iio: light: add VEML6040 RGBW-LS bindings
> > >
> > > On 27/05/2024 17:12, Arthur Becker via B4 Relay wrote:  
> > > > From: Arthur Becker <arthur.becker@sentec.com>
> > > >
> > > > Device tree bindings for the vishay VEML6040 RGBW light sensor iio
> > > > driver
> > > >
> > > > Signed-off-by: Arthur Becker <arthur.becker@sentec.com>
> > > > ---
> > > > V1 -> V3: Addressed review comments (v1 of the dt-bindings was sent
> > > > along with v2 of the driver but not in a set)  
> > >
> > > It's basically the same as veml6075, so should be put there...
> > >
> > > Eh,
> > >
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > >
> > > Best regards,
> > > Krzysztof
> > >  
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml b/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml
new file mode 100644
index 000000000000..101c2cc6506e
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6040.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/light/vishay,veml6040.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VEML6040 RGBW Light Sensor
+
+maintainers:
+  - Arthur Becker <arthur.becker@sentec.com>
+
+description:
+  Datasheet at https://www.vishay.com/docs/84276/veml6040.pdf
+
+properties:
+  compatible:
+    const: vishay,veml6040
+
+  reg:
+    enum:
+      - 0x10
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        light-sensor@10 {
+            compatible = "vishay,veml6040";
+            reg = <0x10>;
+            vdd-supply = <&vdd_reg>;
+        };
+    };
+...