| Message ID | 20240708114227.18283-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/2] dt-bindings: iio: light: ltrf216a: Document LTR-308 support | expand |
On 08/07/2024 13:41, Marek Vasut wrote: > Document LiteOn LTR-308 support in LTR-F216A bindings. > > The two devices seem to have almost identical register map, except that > the LTR-308 does not have three CLEAR_DATA registers, which are unused > by this driver. Furthermore, LTR-308 and LTR-F216A use different lux > calculation constants, 0.6 and 0.45 respectively. > > https://optoelectronics.liteon.com/upload/download/DS86-2016-0027/LTR-308ALS_Final_%20DS_V1%201.pdf > https://optoelectronics.liteon.com/upload/download/DS86-2019-0016/LTR-F216A_Final_DS_V1.4.PDF > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, 9 Jul 2024 10:26:17 +0200 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On 08/07/2024 13:41, Marek Vasut wrote: > > Document LiteOn LTR-308 support in LTR-F216A bindings. > > > > The two devices seem to have almost identical register map, except that > > the LTR-308 does not have three CLEAR_DATA registers, which are unused > > by this driver. Furthermore, LTR-308 and LTR-F216A use different lux > > calculation constants, 0.6 and 0.45 respectively. > > > > https://optoelectronics.liteon.com/upload/download/DS86-2016-0027/LTR-308ALS_Final_%20DS_V1%201.pdf > > https://optoelectronics.liteon.com/upload/download/DS86-2019-0016/LTR-F216A_Final_DS_V1.4.PDF > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Applied to the testing branch of iio.git which will get rebase on rc1 once available. One minor request for future series. For any multipatch series it's helpful to have a cover letter even if there isn't a lot to say. It always provides 2 things that are useful: 1) A title for the series in patchwork. 2) A place for people to give tags for the whole series in a fashion that automation like b4 can pick up. Anyhow, not important for a 2 patch series, but a nice to have! Jonathan > > Best regards, > Krzysztof >
On 7/13/24 1:06 PM, Jonathan Cameron wrote: > On Tue, 9 Jul 2024 10:26:17 +0200 > Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> On 08/07/2024 13:41, Marek Vasut wrote: >>> Document LiteOn LTR-308 support in LTR-F216A bindings. >>> >>> The two devices seem to have almost identical register map, except that >>> the LTR-308 does not have three CLEAR_DATA registers, which are unused >>> by this driver. Furthermore, LTR-308 and LTR-F216A use different lux >>> calculation constants, 0.6 and 0.45 respectively. >>> >>> https://optoelectronics.liteon.com/upload/download/DS86-2016-0027/LTR-308ALS_Final_%20DS_V1%201.pdf >>> https://optoelectronics.liteon.com/upload/download/DS86-2019-0016/LTR-F216A_Final_DS_V1.4.PDF >>> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Applied to the testing branch of iio.git which will get rebase on rc1 once available. > > One minor request for future series. For any multipatch series it's helpful > to have a cover letter even if there isn't a lot to say. It always provides > 2 things that are useful: > 1) A title for the series in patchwork. > 2) A place for people to give tags for the whole series in a fashion that > automation like b4 can pick up. ACK, I really should work on the cover letters, not just here, thanks for the reminder.
diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml index 7de1b0e721ca2..877e955d4ebd1 100644 --- a/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltrf216a.yaml @@ -14,7 +14,9 @@ description: properties: compatible: - const: liteon,ltrf216a + enum: + - liteon,ltr308 + - liteon,ltrf216a reg: maxItems: 1
Document LiteOn LTR-308 support in LTR-F216A bindings. The two devices seem to have almost identical register map, except that the LTR-308 does not have three CLEAR_DATA registers, which are unused by this driver. Furthermore, LTR-308 and LTR-F216A use different lux calculation constants, 0.6 and 0.45 respectively. https://optoelectronics.liteon.com/upload/download/DS86-2016-0027/LTR-308ALS_Final_%20DS_V1%201.pdf https://optoelectronics.liteon.com/upload/download/DS86-2019-0016/LTR-F216A_Final_DS_V1.4.PDF Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Jonathan Cameron <jic23@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Marek Vasut <marex@denx.de> Cc: Rob Herring <robh@kernel.org> Cc: Shreeya Patel <shreeya.patel@collabora.com> Cc: devicetree@vger.kernel.org Cc: linux-iio@vger.kernel.org --- .../devicetree/bindings/iio/light/liteon,ltrf216a.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)