| Message ID | 20240710-ens21x-v3-1-4e3fbcf2a7fb@thegoodpenguin.co.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: humidity: Add support for en21x sensor family | expand |
On Wed, 10 Jul 2024 14:24:04 +0100, Joshua Felmeden wrote: > Add device tree documentation for ENS21x family of temperature and > humidity sensors > > Signed-off-by: Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> > --- > .../bindings/iio/humidity/sciosense,ens21x.yaml | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On Wed, 10 Jul 2024 14:24:04 +0100 Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> wrote: > Add device tree documentation for ENS21x family of temperature and > humidity sensors > > Signed-off-by: Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> > --- > .../bindings/iio/humidity/sciosense,ens21x.yaml | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml > new file mode 100644 > index 000000000000..425d3b57f701 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/humidity/sciosense,ens21x.yaml# Normally we don't allow wild cares in binding names, but in this case the datasheet uses this wild cards, so I guess we have strong guarantees the manufacturer won't slip something else in the gaps. Even with that in mind I'd rather this was sciosense,ens210.yaml As much as anything as to not provide more precedence for wild cards in binding names that might lead people astray when they don't have such strong guarantees. Otherwise looks fine to me. Jonathan > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ScioSense ENS21x temperature and humidity sensor > + > +maintainers: > + - Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> > + > +description: | > + Temperature and Humidity sensor. > + > + Datasheet: > + https://www.sciosense.com/wp-content/uploads/2024/04/ENS21x-Datasheet.pdf > + https://www.sciosense.com/wp-content/uploads/2023/12/ENS210-Datasheet.pdf > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - sciosense,ens210a > + - sciosense,ens211 > + - sciosense,ens212 > + - sciosense,ens213a > + - sciosense,ens215 > + - const: sciosense,ens210 > + - const: sciosense,ens210 > + > + reg: > + maxItems: 1 > + > + vdd-supply: true > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + temperature-sensor@43 { > + compatible = "sciosense,ens210"; > + reg = <0x43>; > + }; > + }; > +... > + >
diff --git a/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml new file mode 100644 index 000000000000..425d3b57f701 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/humidity/sciosense,ens21x.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/humidity/sciosense,ens21x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ScioSense ENS21x temperature and humidity sensor + +maintainers: + - Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> + +description: | + Temperature and Humidity sensor. + + Datasheet: + https://www.sciosense.com/wp-content/uploads/2024/04/ENS21x-Datasheet.pdf + https://www.sciosense.com/wp-content/uploads/2023/12/ENS210-Datasheet.pdf + +properties: + compatible: + oneOf: + - items: + - enum: + - sciosense,ens210a + - sciosense,ens211 + - sciosense,ens212 + - sciosense,ens213a + - sciosense,ens215 + - const: sciosense,ens210 + - const: sciosense,ens210 + + reg: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@43 { + compatible = "sciosense,ens210"; + reg = <0x43>; + }; + }; +... +
Add device tree documentation for ENS21x family of temperature and humidity sensors Signed-off-by: Joshua Felmeden <jfelmeden@thegoodpenguin.co.uk> --- .../bindings/iio/humidity/sciosense,ens21x.yaml | 55 ++++++++++++++++++++++ 1 file changed, 55 insertions(+)