[v7,4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml

Commit Message

Kim Seer Paller July 14, 2024, 1:29 p.m. UTC

Add documentation for ltc2664.

Co-developed-by: Michael Hennerich <[e-mail]>
Signed-off-by: Michael Hennerich <[e-mail]>
Signed-off-by: Kim Seer Paller <[e-mail]>
---
 .../bindings/iio/dac/adi,ltc2664.yaml         | 181 ++++++++++++++++++
 MAINTAINERS                                   |   8 +
 2 files changed, 189 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml

Comments

Krzysztof Kozlowski July 15, 2024, 7:22 a.m. UTC | #1

On 14/07/2024 15:29, Kim Seer Paller wrote:
> Add documentation for ltc2664.
> 
> Co-developed-by: Michael Hennerich <[e-mail]>
> Signed-off-by: Michael Hennerich <[e-mail]>
> Signed-off-by: Kim Seer Paller <[e-mail]>

...

> +
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            channel@0 {
> +                    reg = <0>;
> +                    adi,toggle-mode;
> +                    output-range-microvolt = <(-10000000) 10000000>;

Mixed indentation.

Best regards,
Krzysztof

Conor Dooley July 15, 2024, 4:18 p.m. UTC | #2

On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> Add documentation for ltc2664.
> 
> Co-developed-by: Michael Hennerich <[e-mail]>
> Signed-off-by: Michael Hennerich <[e-mail]>
> Signed-off-by: Kim Seer Paller <[e-mail]>

IIRC I gave you a reviewed-by on v5, was there a particular reason you
didn't add it?

Kim Seer Paller July 16, 2024, 1:50 a.m. UTC | #3

> -----Original Message-----
> From: Conor Dooley <[e-mail]>
> Sent: Tuesday, July 16, 2024 12:18 AM
> To: Paller, Kim Seer <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; Jonathan Cameron <[e-mail]>; David
> Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> Liam Girdwood <[e-mail]>; Mark Brown <[e-mail]>;
> Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> <[e-mail]>; Hennerich, Michael
> <[e-mail]>; Nuno Sá <[e-mail]>
> Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> 
> [External]
> 
> On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > Add documentation for ltc2664.
> >
> > Co-developed-by: Michael Hennerich <[e-mail]>
> > Signed-off-by: Michael Hennerich <[e-mail]>
> > Signed-off-by: Kim Seer Paller <[e-mail]>
> 
> IIRC I gave you a reviewed-by on v5, was there a particular reason you didn't
> add it?

I made changes to the 'output-range-microvolt' logic in v6, which I thought
might require a new review. If your 'Reviewed-by' tag still applies, please let me know.

Thanks,
Kim

Conor Dooley July 16, 2024, 3:57 p.m. UTC | #4

On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <[e-mail]>
> > Sent: Tuesday, July 16, 2024 12:18 AM
> > To: Paller, Kim Seer <[e-mail]>
> > Cc: [e-mail]; [e-mail];
> > [e-mail]; Jonathan Cameron <[e-mail]>; David
> > Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> > Liam Girdwood <[e-mail]>; Mark Brown <[e-mail]>;
> > Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> > <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> > <[e-mail]>; Hennerich, Michael
> > <[e-mail]>; Nuno Sá <[e-mail]>
> > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > 
> > [External]
> > 
> > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > > Add documentation for ltc2664.
> > >
> > > Co-developed-by: Michael Hennerich <[e-mail]>
> > > Signed-off-by: Michael Hennerich <[e-mail]>
> > > Signed-off-by: Kim Seer Paller <[e-mail]>
> > 
> > IIRC I gave you a reviewed-by on v5, was there a particular reason you didn't
> > add it?
> 
> I made changes to the 'output-range-microvolt' logic in v6, which I thought
> might require a new review. If your 'Reviewed-by' tag still applies, please let me know.

IIRC what I said was along the lines of "with the logic from the
previous version, Reviewed-by: Conor Dooley <[e-mail]>".
Is that what you did?

Kim Seer Paller July 17, 2024, 1:07 a.m. UTC | #5

> -----Original Message-----
> From: Conor Dooley <[e-mail]>
> Sent: Tuesday, July 16, 2024 11:58 PM
> To: Paller, Kim Seer <[e-mail]>
> Cc: [e-mail]; [e-mail];
> [e-mail]; Jonathan Cameron <[e-mail]>; David
> Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> Liam Girdwood <[e-mail]>; Mark Brown <[e-mail]>;
> Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> <[e-mail]>; Hennerich, Michael
> <[e-mail]>; Nuno Sá <[e-mail]>
> Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> 
> [External]
> 
> On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote:
> >
> >
> > > -----Original Message-----
> > > From: Conor Dooley <[e-mail]>
> > > Sent: Tuesday, July 16, 2024 12:18 AM
> > > To: Paller, Kim Seer <[e-mail]>
> > > Cc: [e-mail]; [e-mail];
> > > [e-mail]; Jonathan Cameron <[e-mail]>; David
> > > Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> > > Liam Girdwood <[e-mail]>; Mark Brown
> <[e-mail]>;
> > > Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> > > <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> > > <[e-mail]>; Hennerich, Michael
> > > <[e-mail]>; Nuno Sá <[e-mail]>
> > > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > >
> > > [External]
> > >
> > > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > > > Add documentation for ltc2664.
> > > >
> > > > Co-developed-by: Michael Hennerich <[e-mail]>
> > > > Signed-off-by: Michael Hennerich <[e-mail]>
> > > > Signed-off-by: Kim Seer Paller <[e-mail]>
> > >
> > > IIRC I gave you a reviewed-by on v5, was there a particular reason you
> didn't
> > > add it?
> >
> > I made changes to the 'output-range-microvolt' logic in v6, which I thought
> > might require a new review. If your 'Reviewed-by' tag still applies, please let
> me know.
> 
> IIRC what I said was along the lines of "with the logic from the
> previous version, Reviewed-by: Conor Dooley <[e-mail]>".
> Is that what you did?

Yes. Additionally, considering Krzysztof's recent comment about the mixed 
indentation in the example section, should I send a new patch version that
includes this indentation fix along with adding your Reviewed-by tag?

Conor Dooley July 17, 2024, 2:33 p.m. UTC | #6

On Wed, Jul 17, 2024 at 01:07:31AM +0000, Paller, Kim Seer wrote:
> 
> 
> > -----Original Message-----
> > From: Conor Dooley <[e-mail]>
> > Sent: Tuesday, July 16, 2024 11:58 PM
> > To: Paller, Kim Seer <[e-mail]>
> > Cc: [e-mail]; [e-mail];
> > [e-mail]; Jonathan Cameron <[e-mail]>; David
> > Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> > Liam Girdwood <[e-mail]>; Mark Brown <[e-mail]>;
> > Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> > <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> > <[e-mail]>; Hennerich, Michael
> > <[e-mail]>; Nuno Sá <[e-mail]>
> > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > 
> > [External]
> > 
> > On Tue, Jul 16, 2024 at 01:50:23AM +0000, Paller, Kim Seer wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Conor Dooley <[e-mail]>
> > > > Sent: Tuesday, July 16, 2024 12:18 AM
> > > > To: Paller, Kim Seer <[e-mail]>
> > > > Cc: [e-mail]; [e-mail];
> > > > [e-mail]; Jonathan Cameron <[e-mail]>; David
> > > > Lechner <[e-mail]>; Lars-Peter Clausen <[e-mail]>;
> > > > Liam Girdwood <[e-mail]>; Mark Brown
> > <[e-mail]>;
> > > > Dimitri Fedrau <[e-mail]>; Krzysztof Kozlowski
> > > > <[e-mail]>; Rob Herring <[e-mail]>; Conor Dooley
> > > > <[e-mail]>; Hennerich, Michael
> > > > <[e-mail]>; Nuno Sá <[e-mail]>
> > > > Subject: Re: [PATCH v7 4/6] dt-bindings: iio: dac: Add adi,ltc2664.yaml
> > > >
> > > > [External]
> > > >
> > > > On Sun, Jul 14, 2024 at 09:29:58PM +0800, Kim Seer Paller wrote:
> > > > > Add documentation for ltc2664.
> > > > >
> > > > > Co-developed-by: Michael Hennerich <[e-mail]>
> > > > > Signed-off-by: Michael Hennerich <[e-mail]>
> > > > > Signed-off-by: Kim Seer Paller <[e-mail]>
> > > >
> > > > IIRC I gave you a reviewed-by on v5, was there a particular reason you
> > didn't
> > > > add it?
> > >
> > > I made changes to the 'output-range-microvolt' logic in v6, which I thought
> > > might require a new review. If your 'Reviewed-by' tag still applies, please let
> > me know.
> > 
> > IIRC what I said was along the lines of "with the logic from the
> > previous version, Reviewed-by: Conor Dooley <[e-mail]>".
> > Is that what you did?
> 
> Yes. Additionally, considering Krzysztof's recent comment about the mixed 
> indentation in the example section, should I send a new patch version that
> includes this indentation fix along with adding your Reviewed-by tag?

Seems reasonable to me, thanks.

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml
new file mode 100644
index 000000000000..84488437b788
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml
@@ -0,0 +1,181 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/adi,ltc2664.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices LTC2664 DAC
+
+maintainers:
+  - Michael Hennerich <[e-mail]>
+  - Kim Seer Paller <[e-mail]>
+
+description: |
+  Analog Devices LTC2664 4 channel, 12-/16-Bit, +-10V DAC
+  https://www.analog.com/media/en/technical-documentation/data-sheets/2664fa.pdf
+
+properties:
+  compatible:
+    enum:
+      - adi,ltc2664
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 50000000
+
+  vcc-supply:
+    description: Analog Supply Voltage Input.
+
+  v-pos-supply:
+    description: Positive Supply Voltage Input.
+
+  v-neg-supply:
+    description: Negative Supply Voltage Input.
+
+  iovcc-supply:
+    description: Digital Input/Output Supply Voltage.
+
+  ref-supply:
+    description:
+      Reference Input/Output. The voltage at the REF pin sets the full-scale
+      range of all channels. If not provided the internal reference is used and
+      also provided on the VREF pin.
+
+  reset-gpios:
+    description:
+      Active-low Asynchronous Clear Input. A logic low at this level-triggered
+      input clears the part to the reset code and range determined by the
+      hardwired option chosen using the MSPAN pins. The control registers are
+      cleared to zero.
+    maxItems: 1
+
+  adi,manual-span-operation-config:
+    description:
+      This property must mimic the MSPAN pin configurations. By tying the MSPAN
+      pins (MSP2, MSP1 and MSP0) to GND and/or VCC, any output range can be
+      hardware-configured with different mid-scale or zero-scale reset options.
+      The hardware configuration is latched during power on reset for proper
+      operation.
+        0 - MPS2=GND, MPS1=GND, MSP0=GND (+-10V, reset to 0V)
+        1 - MPS2=GND, MPS1=GND, MSP0=VCC (+-5V, reset to 0V)
+        2 - MPS2=GND, MPS1=VCC, MSP0=GND (+-2.5V, reset to 0V)
+        3 - MPS2=GND, MPS1=VCC, MSP0=VCC (0V to 10, reset to 0V)
+        4 - MPS2=VCC, MPS1=GND, MSP0=GND (0V to 10V, reset to 5V)
+        5 - MPS2=VCC, MPS1=GND, MSP0=VCC (0V to 5V, reset to 0V)
+        6 - MPS2=VCC, MPS1=VCC, MSP0=GND (0V to 5V, reset to 2.5V)
+        7 - MPS2=VCC, MPS1=VCC, MSP0=VCC (0V to 5V, reset to 0V, enables SoftSpan)
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [0, 1, 2, 3, 4, 5, 6, 7]
+    default: 7
+
+  io-channels:
+    description:
+      ADC channel to monitor voltages and temperature at the MUXOUT pin.
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+patternProperties:
+  "^channel@[0-3]$":
+    $ref: dac.yaml
+    type: object
+    additionalProperties: false
+
+    properties:
+      reg:
+        description: The channel number representing the DAC output channel.
+        maximum: 3
+
+      adi,toggle-mode:
+        description:
+          Set the channel as a toggle enabled channel. Toggle operation enables
+          fast switching of a DAC output between two different DAC codes without
+          any SPI transaction.
+        type: boolean
+
+      output-range-microvolt:
+        description:
+          This property is only allowed when SoftSpan is enabled. If not present,
+          [0, 5000000] is the default output range.
+        oneOf:
+          - items:
+              - const: 0
+              - enum: [5000000, 10000000]
+          - items:
+              - const: -5000000
+              - const: 5000000
+          - items:
+              - const: -10000000
+              - const: 10000000
+          - items:
+              - const: -2500000
+              - const: 2500000
+
+    required:
+      - reg
+
+    allOf:
+      - if:
+          not:
+            properties:
+              adi,manual-span-operation-config:
+                const: 7
+        then:
+          patternProperties:
+            "^channel@[0-3]$":
+              properties:
+                output-range-microvolt: false
+
+required:
+  - compatible
+  - reg
+  - spi-max-frequency
+  - vcc-supply
+  - iovcc-supply
+  - v-pos-supply
+  - v-neg-supply
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        dac@0 {
+            compatible = "adi,ltc2664";
+            reg = <0>;
+            spi-max-frequency = <10000000>;
+
+            vcc-supply = <&vcc>;
+            iovcc-supply = <&vcc>;
+            ref-supply = <&vref>;
+            v-pos-supply = <&vpos>;
+            v-neg-supply = <&vneg>;
+
+            io-channels = <&adc 0>;
+
+            #address-cells = <1>;
+            #size-cells = <0>;
+            channel@0 {
+                    reg = <0>;
+                    adi,toggle-mode;
+                    output-range-microvolt = <(-10000000) 10000000>;
+            };
+
+            channel@1 {
+                    reg = <1>;
+                    output-range-microvolt= <0 10000000>;
+            };
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 06ecfa64a39a..c25863321328 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13080,6 +13080,14 @@  S:	Maintained
 F:	Documentation/devicetree/bindings/iio/dac/lltc,ltc1660.yaml
 F:	drivers/iio/dac/ltc1660.c
 
+LTC2664 IIO DAC DRIVER
+M:	Michael Hennerich <[e-mail]>
+M:	Kim Seer Paller <[e-mail]>
+L:	[e-mail]
+S:	Supported
+W:	https://ez.analog.com/linux-software-drivers
+F:	Documentation/devicetree/bindings/iio/dac/adi,ltc2664.yaml
+
 LTC2688 IIO DAC DRIVER
 M:	Nuno Sá <[e-mail]>
 L:	[e-mail]