diff mbox series

[06/23] iio: adc: rockchip_saradc: make use of iio_for_each_active_channel()

Message ID 20240726-dev-iio-masklength-private3-v1-6-82913fc0fb87@analog.com (mailing list archive)
State Accepted
Headers show
Series iio: make masklength __private (final round) | expand

Commit Message

Nuno Sa via B4 Relay July 26, 2024, 8:22 a.m. UTC
From: Nuno Sa <nuno.sa@analog.com>

Use iio_for_each_active_channel() to iterate over active channels
accessing '.masklength' so it can be annotated as __private when there are
no more direct users of it.

Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
 drivers/iio/adc/rockchip_saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stübner July 29, 2024, 4:52 p.m. UTC | #1
Am Freitag, 26. Juli 2024, 10:22:58 CEST schrieb Nuno Sa via B4 Relay:
> From: Nuno Sa <nuno.sa@analog.com>
> 
> Use iio_for_each_active_channel() to iterate over active channels
> accessing '.masklength' so it can be annotated as __private when there are
> no more direct users of it.
> 
> Signed-off-by: Nuno Sa <nuno.sa@analog.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/iio/adc/rockchip_saradc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index bbe954a738c7..71f58e3a8307 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -370,7 +370,7 @@ static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)
>  
>  	mutex_lock(&info->lock);
>  
> -	for_each_set_bit(i, i_dev->active_scan_mask, i_dev->masklength) {
> +	iio_for_each_active_channel(i_dev, i) {
>  		const struct iio_chan_spec *chan = &i_dev->channels[i];
>  
>  		ret = rockchip_saradc_conversion(info, chan);
> 
>
diff mbox series

Patch

diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index bbe954a738c7..71f58e3a8307 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -370,7 +370,7 @@  static irqreturn_t rockchip_saradc_trigger_handler(int irq, void *p)
 
 	mutex_lock(&info->lock);
 
-	for_each_set_bit(i, i_dev->active_scan_mask, i_dev->masklength) {
+	iio_for_each_active_channel(i_dev, i) {
 		const struct iio_chan_spec *chan = &i_dev->channels[i];
 
 		ret = rockchip_saradc_conversion(info, chan);