diff mbox series

[v2,2/3] dt-bindings: iio: imu: magnetometer: Add ak09118

Message ID 20240806-ak09918-v2-2-c300da66c198@mainlining.org (mailing list archive)
State Changes Requested
Headers show
Series Add support for AK09918 | expand

Commit Message

Barnabás Czémán Aug. 6, 2024, 6:10 a.m. UTC 
From: Danila Tikhonov <danila@jiaxyga.com>

Document asahi-kasei,ak09918 compatible.

Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml         | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Aug. 6, 2024, 4 p.m. UTC | #1 
On Tue, Aug 06, 2024 at 08:10:19AM +0200, Barnabás Czémán wrote:
> From: Danila Tikhonov <danila@jiaxyga.com>
> 
> Document asahi-kasei,ak09918 compatible.

Please explain what makes this device incompatible with those already in
the binding and why a fallback is not suitable.

Thanks,
Conor.

> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  .../devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> index 9790f75fc669..583cdd2fad7e 100644
> --- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
> @@ -18,6 +18,7 @@ properties:
>            - asahi-kasei,ak09911
>            - asahi-kasei,ak09912
>            - asahi-kasei,ak09916
> +          - asahi-kasei,ak09918
>        - enum:
>            - ak8975
>            - ak8963
> 
> -- 
> 2.46.0
>
Conor Dooley Aug. 6, 2024, 4:01 p.m. UTC | #2 
On Tue, Aug 06, 2024 at 05:00:44PM +0100, Conor Dooley wrote:
> On Tue, Aug 06, 2024 at 08:10:19AM +0200, Barnabás Czémán wrote:
> > From: Danila Tikhonov <danila@jiaxyga.com>
> > 
> > Document asahi-kasei,ak09918 compatible.
> 
> Please explain what makes this device incompatible with those already in
> the binding and why a fallback is not suitable.

From the driver patch:
| Add additional AK09118 to the magnetometer driver which has the same
| register mapping and scaling as the AK09112 device.

Why isnt a fallback suitable here?
Krzysztof Kozlowski Aug. 7, 2024, 6:03 a.m. UTC | #3 
On 06/08/2024 08:10, Barnabás Czémán wrote:
> From: Danila Tikhonov <danila@jiaxyga.com>
> 
> Document asahi-kasei,ak09918 compatible.
> 
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
index 9790f75fc669..583cdd2fad7e 100644
--- a/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
+++ b/Documentation/devicetree/bindings/iio/magnetometer/asahi-kasei,ak8975.yaml
@@ -18,6 +18,7 @@  properties:
           - asahi-kasei,ak09911
           - asahi-kasei,ak09912
           - asahi-kasei,ak09916
+          - asahi-kasei,ak09918
       - enum:
           - ak8975
           - ak8963