| Message ID | 20240809-ad4113-v2-1-2a70c101a1f4@analog.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for AD4113 | expand |
On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote: > From: Dumitru Ceclan <dumitru.ceclan@analog.com> > > This commit adds bindings support for AD4113. > > The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital > converter (ADC) that integrates an analog front end (AFE) for four > fully differential or eight single-ended inputs. > > Added ad4113 to the compatible list and the "avdd2-supply: false" > restriction. > > Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > index 17c5d39cc2c1..ad15cf9bc2ff 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > @@ -28,6 +28,7 @@ description: | > Datasheets for supported chips: > https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf > https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf > + <AD4113: not released yet> Am I meant to ack it with this placeholder? When will the document be released? Acked-by: Conor Dooley <conor.dooley@microchip.com> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf > https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf > https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf > @@ -44,6 +45,7 @@ properties: > enum: > - adi,ad4111 > - adi,ad4112 > + - adi,ad4113 > - adi,ad4114 > - adi,ad4115 > - adi,ad4116 > @@ -331,6 +333,7 @@ allOf: > enum: > - adi,ad4111 > - adi,ad4112 > + - adi,ad4113 > - adi,ad4114 > - adi,ad4115 > - adi,ad4116 > > -- > 2.43.0 > >
On 09/08/2024 17:21, Conor Dooley wrote: > On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote: >> From: Dumitru Ceclan <dumitru.ceclan@analog.com> >> >> This commit adds bindings support for AD4113. >> >> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital >> converter (ADC) that integrates an analog front end (AFE) for four >> fully differential or eight single-ended inputs. >> >> Added ad4113 to the compatible list and the "avdd2-supply: false" >> restriction. >> >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com> >> --- >> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml >> index 17c5d39cc2c1..ad15cf9bc2ff 100644 >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml >> @@ -28,6 +28,7 @@ description: | >> Datasheets for supported chips: >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf >> + <AD4113: not released yet> > > Am I meant to ack it with this placeholder? When will the document be > released? > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Not really sure tbh, up to you. The document will be released in the upcoming months. If it's considered best to wait until the docs are public and send another version with the correct link. If not, and maintainers consider that these changes can be accepted even without viewing the datasheet, I'll send a patch when it goes public. >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf >> @@ -44,6 +45,7 @@ properties: >> enum: >> - adi,ad4111 >> - adi,ad4112 >> + - adi,ad4113 >> - adi,ad4114 >> - adi,ad4115 >> - adi,ad4116 >> @@ -331,6 +333,7 @@ allOf: >> enum: >> - adi,ad4111 >> - adi,ad4112 >> + - adi,ad4113 >> - adi,ad4114 >> - adi,ad4115 >> - adi,ad4116 >> >> -- >> 2.43.0 >> >>
On Fri, Aug 09, 2024 at 05:32:08PM +0300, Ceclan, Dumitru wrote: > On 09/08/2024 17:21, Conor Dooley wrote: > > On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote: > >> From: Dumitru Ceclan <dumitru.ceclan@analog.com> > >> > >> This commit adds bindings support for AD4113. > >> > >> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital > >> converter (ADC) that integrates an analog front end (AFE) for four > >> fully differential or eight single-ended inputs. > >> > >> Added ad4113 to the compatible list and the "avdd2-supply: false" > >> restriction. > >> > >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com> > >> --- > >> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > >> index 17c5d39cc2c1..ad15cf9bc2ff 100644 > >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > >> @@ -28,6 +28,7 @@ description: | > >> Datasheets for supported chips: > >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf > >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf > >> + <AD4113: not released yet> > > > > Am I meant to ack it with this placeholder? When will the document be > > released? > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > Not really sure tbh, up to you. The document will be released in the upcoming months. > > If it's considered best to wait until the docs are public and send another > version with the correct link. > If not, and maintainers consider that these changes can be accepted even > without viewing the datasheet, I'll send a patch when it goes public. I don't really care, it's just to Jonathan I think. I'm happy enough with you adding it when it is released.
On Fri, 9 Aug 2024 16:09:07 +0100 Conor Dooley <conor@kernel.org> wrote: > On Fri, Aug 09, 2024 at 05:32:08PM +0300, Ceclan, Dumitru wrote: > > On 09/08/2024 17:21, Conor Dooley wrote: > > > On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote: > > >> From: Dumitru Ceclan <dumitru.ceclan@analog.com> > > >> > > >> This commit adds bindings support for AD4113. > > >> > > >> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital > > >> converter (ADC) that integrates an analog front end (AFE) for four > > >> fully differential or eight single-ended inputs. > > >> > > >> Added ad4113 to the compatible list and the "avdd2-supply: false" > > >> restriction. > > >> > > >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com> > > >> --- > > >> Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++ > > >> 1 file changed, 3 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > > >> index 17c5d39cc2c1..ad15cf9bc2ff 100644 > > >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > > >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > > >> @@ -28,6 +28,7 @@ description: | > > >> Datasheets for supported chips: > > >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf > > >> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf > > >> + <AD4113: not released yet> > > > > > > Am I meant to ack it with this placeholder? When will the document be > > > released? > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > > Not really sure tbh, up to you. The document will be released in the upcoming months. > > > > If it's considered best to wait until the docs are public and send another > > version with the correct link. > > If not, and maintainers consider that these changes can be accepted even > > without viewing the datasheet, I'll send a patch when it goes public. > > I don't really care, it's just to Jonathan I think. I'm happy enough > with you adding it when it is released. Given some companies never release public docs (mine for example rarely does) there is no requirement for datasheets. So this is fine, particularly if you come back with a link when it is available. Thanks, Jonathan
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml index 17c5d39cc2c1..ad15cf9bc2ff 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml @@ -28,6 +28,7 @@ description: | Datasheets for supported chips: https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf + <AD4113: not released yet> https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf @@ -44,6 +45,7 @@ properties: enum: - adi,ad4111 - adi,ad4112 + - adi,ad4113 - adi,ad4114 - adi,ad4115 - adi,ad4116 @@ -331,6 +333,7 @@ allOf: enum: - adi,ad4111 - adi,ad4112 + - adi,ad4113 - adi,ad4114 - adi,ad4115 - adi,ad4116