[v3,1/2] dt-bindings: iio: imu: smi240: devicetree binding

Commit Message

Shen Jianping (ME-SE/EAD2) Aug. 15, 2024, 3:25 p.m. UTC

From: Shen Jianping <[e-mail]>

dt-bindings: iio: imu: smi240: add sensor dt-binding
Signed-off-by: Shen Jianping <[e-mail]>
---

Notes:
    v1 -> v2
    - Add more detail in description
    - Add maintainer
    - Add vdd and vddio power supply
    - Use generic node name
    - Order the properties according to DTS coding style
    
    v2 -> v3
    - improve description
    - improve supply definition
    - make supply definition as required
    - add supply definition in example

 .../bindings/iio/imu/bosch,smi240.yaml        | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml

Comments

Conor Dooley Aug. 15, 2024, 3:34 p.m. UTC | #1

On Thu, Aug 15, 2024 at 05:25:44PM +0200, [e-mail] wrote:
> From: Shen Jianping <[e-mail]>
> 
> dt-bindings: iio: imu: smi240: add sensor dt-binding
> Signed-off-by: Shen Jianping <[e-mail]>

There should be a blank line between the body of the commit message and
the signoff. That said, the body here just repeats $subject - but really
should be something more like the description in the binding.

Conor Dooley Aug. 15, 2024, 3:38 p.m. UTC | #2

On Thu, Aug 15, 2024 at 04:34:05PM +0100, Conor Dooley wrote:
> On Thu, Aug 15, 2024 at 05:25:44PM +0200, [e-mail] wrote:
> > From: Shen Jianping <[e-mail]>
> > 
> > dt-bindings: iio: imu: smi240: add sensor dt-binding
> > Signed-off-by: Shen Jianping <[e-mail]>
> 
> There should be a blank line between the body of the commit message and
> the signoff. That said, the body here just repeats $subject - but really
> should be something more like the description in the binding.

Crap, I meant to say that with a fixed commit message,
Reviewed-by: Conor Dooley <[e-mail]>

Thanks,
Conor.

Krzysztof Kozlowski Aug. 16, 2024, 7:26 a.m. UTC | #3

On 15/08/2024 17:25, [e-mail] wrote:
> From: Shen Jianping <[e-mail]>
> 
> dt-bindings: iio: imu: smi240: add sensor dt-binding

Nothing improved. Please write proper commit msgs. See
submitting-patches document.

> Signed-off-by: Shen Jianping <[e-mail]>
> ---
> 
Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
new file mode 100644
index 00000000000..6f1fb4b892c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
@@ -0,0 +1,52 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/imu/bosch,smi240.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bosch smi240 imu
+
+maintainers:
+  - Jianping Shen <[e-mail]>
+
+description:
+  The smi240 is a combined three axis angular rate and three 
+  axis acceleration sensor module with a measurement range of 
+  +/-300°/s and up to 16g.
+  https://www.bosch-semiconductors.com/mems-sensors/highly-automated-driving/smi240/
+
+properties:
+  compatible:
+    const: bosch,smi240
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+  vddio-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+  - vddio-supply
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        imu@0 {
+            compatible = "bosch,smi240";
+            reg = <0>;
+            vdd-supply = <&vdd>;
+            vddio-supply = <&vddio>;
+            spi-max-frequency = <10000000>;
+        };
+    };