diff mbox series

[2/2] dt-bindings: iio: temperature: tmp006: document interrupt

Message ID 20240902125946.350635-3-apokusinski01@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series iio: temperature: tmp006: support for drdy irq | expand

Commit Message

Antoni Pokusinski Sept. 2, 2024, 12:59 p.m. UTC
Update the example with interrupt bindings and add "interrupts" property

Signed-off-by: Antoni Pokusinski <apokusinski01@gmail.com>
---
 .../devicetree/bindings/iio/temperature/ti,tmp006.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski Sept. 2, 2024, 4:04 p.m. UTC | #1
On 02/09/2024 14:59, Antoni Pokusinski wrote:
> Update the example with interrupt bindings and add "interrupts" property

But why? Commit msg should answer this question. E.g. because hardware
has interrupts or any other hardware-related reason

Best regards,
Krzysztof
Krzysztof Kozlowski Sept. 3, 2024, 7:05 a.m. UTC | #2
On Mon, Sep 02, 2024 at 06:04:15PM +0200, Krzysztof Kozlowski wrote:
> On 02/09/2024 14:59, Antoni Pokusinski wrote:
> > Update the example with interrupt bindings and add "interrupts" property
> 
> But why? Commit msg should answer this question. E.g. because hardware
> has interrupts or any other hardware-related reason
> 

And please point me which pin on the diagram/schematics is the interrupt
pin.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml
index d43002b9bfdc..590f50ba3a31 100644
--- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp006.yaml
@@ -23,6 +23,9 @@  properties:
   vdd-supply:
     description: provide VDD power to the sensor.
 
+  interrupts:
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -31,6 +34,7 @@  additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/interrupt-controller/irq.h>
     i2c {
         #address-cells = <1>;
         #size-cells = <0>;
@@ -38,5 +42,7 @@  examples:
             compatible = "ti,tmp006";
             reg = <0x40>;
             vdd-supply = <&ldo4_reg>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
         };
     };