| Message ID | 20240920181437.20194-1-abhashkumarjha123@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: max1363: Convert to get_unaligned_be16 | expand |
On Fri, 20 Sep 2024 23:44:37 +0530 Abhash Jha <abhashkumarjha123@gmail.com> wrote: > Converted manual shifting and or to use `get_unaligned_be16` api > instead. > > Signed-off-by: Abhash Jha <abhashkumarjha123@gmail.com> Applied Thanks, Jonathan > --- > drivers/iio/adc/max1363.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c > index bf4b6dc53..0801317da 100644 > --- a/drivers/iio/adc/max1363.c > +++ b/drivers/iio/adc/max1363.c > @@ -33,6 +33,8 @@ > #include <linux/iio/trigger_consumer.h> > #include <linux/iio/triggered_buffer.h> > > +#include <asm/unaligned.h> > + > #define MAX1363_SETUP_BYTE(a) ((a) | 0x80) > > /* There is a fair bit more defined here than currently > @@ -391,7 +393,7 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev, > if (data < 0) > return data; > > - data = (rxbuf[1] | rxbuf[0] << 8) & > + data = get_unaligned_be16(rxbuf) & > ((1 << st->chip_info->bits) - 1); > } else { > /* Get reading */
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c index bf4b6dc53..0801317da 100644 --- a/drivers/iio/adc/max1363.c +++ b/drivers/iio/adc/max1363.c @@ -33,6 +33,8 @@ #include <linux/iio/trigger_consumer.h> #include <linux/iio/triggered_buffer.h> +#include <asm/unaligned.h> + #define MAX1363_SETUP_BYTE(a) ((a) | 0x80) /* There is a fair bit more defined here than currently @@ -391,7 +393,7 @@ static int max1363_read_single_chan(struct iio_dev *indio_dev, if (data < 0) return data; - data = (rxbuf[1] | rxbuf[0] << 8) & + data = get_unaligned_be16(rxbuf) & ((1 << st->chip_info->bits) - 1); } else { /* Get reading */
Converted manual shifting and or to use `get_unaligned_be16` api instead. Signed-off-by: Abhash Jha <abhashkumarjha123@gmail.com> --- drivers/iio/adc/max1363.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)