| Message ID | 20240923-veml6035-v2-1-58c72a0df31c@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: light: veml6030: fix issues and add support for veml6035 | expand |
On Mon, 23 Sep 2024 00:17:49 +0200 Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote: > The driver still uses the sensor resolution provided in the datasheet > until Rev. 1.6, 28-Apr-2022, which was updated with Rev 1.7, > 28-Nov-2023. The original ambient light resolution has been updated from > 0.0036 lx/ct to 0.0042 lx/ct, which is the value that can be found in > the current device datasheet. > > Update the default resolution for IT = 100 ms and GAIN = 1/8 from the > original 4608 mlux/cnt to the current value from the "Resolution and > maximum detection range" table (Application Note 84367, page 5), 5376 > mlux/cnt. > > Cc: stable@vger.kernel.org > Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Applied this patch to the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/light/veml6030.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c > index 4c436c5e0787..a3dfe56b7eec 100644 > --- a/drivers/iio/light/veml6030.c > +++ b/drivers/iio/light/veml6030.c > @@ -780,7 +780,7 @@ static int veml6030_hw_init(struct iio_dev *indio_dev) > > /* Cache currently active measurement parameters */ > data->cur_gain = 3; > - data->cur_resolution = 4608; > + data->cur_resolution = 5376; > data->cur_integration_time = 3; > > return ret; >
diff --git a/drivers/iio/light/veml6030.c b/drivers/iio/light/veml6030.c index 4c436c5e0787..a3dfe56b7eec 100644 --- a/drivers/iio/light/veml6030.c +++ b/drivers/iio/light/veml6030.c @@ -780,7 +780,7 @@ static int veml6030_hw_init(struct iio_dev *indio_dev) /* Cache currently active measurement parameters */ data->cur_gain = 3; - data->cur_resolution = 4608; + data->cur_resolution = 5376; data->cur_integration_time = 3; return ret;
The driver still uses the sensor resolution provided in the datasheet until Rev. 1.6, 28-Apr-2022, which was updated with Rev 1.7, 28-Nov-2023. The original ambient light resolution has been updated from 0.0036 lx/ct to 0.0042 lx/ct, which is the value that can be found in the current device datasheet. Update the default resolution for IT = 100 ms and GAIN = 1/8 from the original 4608 mlux/cnt to the current value from the "Resolution and maximum detection range" table (Application Note 84367, page 5), 5376 mlux/cnt. Cc: stable@vger.kernel.org Fixes: 7b779f573c48 ("iio: light: add driver for veml6030 ambient light sensor") Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> --- drivers/iio/light/veml6030.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)