From patchwork Thu Oct 24 13:29:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13849030 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD3FF1DD9D1 for ; Thu, 24 Oct 2024 13:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729776552; cv=none; b=chxvhLRC/1C5xEHIRRAwBMcbqqIw6h+6y/CL2orweEtEHuf5T5qLtOQty4uVea1zVXWYVvW8BBHEcO5+l1fmlaW5gTa29kEaeObUeT3YCV7EjhVpKEoaVm1BdhtFGRsz4AypkLdsr6ff5Cc9CNCuo/fpCWFpaptpoKFl5Xo02NY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729776552; c=relaxed/simple; bh=NTUbVMYf2x+7q0/8Barwlk+9iZKYWLsfR/svD0SOK6M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EY7+xddvjybC0+0zg3Ew78Unc0YHjU0siJz8N5pi1X1MUXK0mWn+MGm8ZmbvSftG9tt3p5zZ31EixxdgTBuD+wFKc3nLQ/CY8gBf43ebamBe+8/h2p55uA2iL14lPtwymK0bT992Edd+DFIAizaE0PAQtaNfGAbOa6C+8zmgXkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MBggSU1S; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MBggSU1S" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7b12a02596aso58582685a.2 for ; Thu, 24 Oct 2024 06:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729776549; x=1730381349; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gQttLL6CFS2JGt87dEF+H1Jt5OZPaXEa5P0U/qvO3f8=; b=MBggSU1SDh8XMM99Bnet7Qijn7f47FNPTREisuC15Ta1JXf0yr0iPgFre/vdLI0/bR ynPbTIFaYR7inb6obo/2l9jjCt0Fim8vTyKAtGfbIFk4DyoL2IncraFmLagcy5keEU/j K4uNpbJPF2r+0UsEerz3yM+s/htsi25UvYp5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729776549; x=1730381349; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQttLL6CFS2JGt87dEF+H1Jt5OZPaXEa5P0U/qvO3f8=; b=VpZzbj56xalyWo64AXamMEYa6Cd3H3+t3oqJRoA3wNZaaboBjymkjZP8N2h6oWu65s WLHKX+CKI2/nHB7GkkNWtfwW1gH0s/xNk9hOf7VacylKtDeb2emmyfyeBrpkqvMdhZOz gy+uz2HL5YlP1ic0xE8lCaHCtufX9ViJdn15F9NxwiEm5jd3mvizJ0D7ZcbkKaVZpNiD LXEcfWyggeO9Z5qn9lM7GwIdO2uiGy06v02pMYqAHpvbFu1xRPLYujJD9bgAdlVIH8tp eLAPIUqWhGWWPy3fnPemMC7vnVq+4eNbTrdH8jcOsGCUxfEgKX+fQKr20O8DoL7b016Z Hu+w== X-Forwarded-Encrypted: i=1; AJvYcCVSIOE6WDsFiN9oM/6QQLHJ78lMo/QngpHHPdJJHkGCOoFd1948X9aJmzD/3ftl6v9tq/s1jLFbX1o=@vger.kernel.org X-Gm-Message-State: AOJu0YwjGFI+Qapqbkt77NqRmieePVE5vh1PbNmTm3uQ5OgMzBDMKT6h jrxJNQkwiiADWEe1g/dSL863sBZJhz0B0vGh7I2EfXu2iB123npUe6FiQ16TNQ== X-Google-Smtp-Source: AGHT+IG7U0KSHWrmCe91AVXiWEDTh9XeuV5+Nzyo+RoW/0JSWl+BTa9POmrQvviAAOmkiVGmWOnsOQ== X-Received: by 2002:a05:620a:2994:b0:7a9:cd41:9c0b with SMTP id af79cd13be357-7b186bb3431mr206876585a.17.1729776548724; Thu, 24 Oct 2024 06:29:08 -0700 (PDT) Received: from denia.c.googlers.com (189.216.85.34.bc.googleusercontent.com. [34.85.216.189]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b165a5d663sm484204885a.94.2024.10.24.06.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 06:29:08 -0700 (PDT) From: Ricardo Ribalda Date: Thu, 24 Oct 2024 13:29:06 +0000 Subject: [PATCH 2/3] iio: hid-sensors-prox: Factor-in hid_sensor_push_data Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241024-hpd-v1-2-2a125882f1f8@chromium.org> References: <20241024-hpd-v1-0-2a125882f1f8@chromium.org> In-Reply-To: <20241024-hpd-v1-0-2a125882f1f8@chromium.org> To: Jiri Kosina , Benjamin Tissoires , Jonathan Cameron , Srinivas Pandruvada , Lars-Peter Clausen Cc: Harvey Yang , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The function is only called from one place and it is a one-liner. Signed-off-by: Ricardo Ribalda --- drivers/iio/light/hid-sensor-prox.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c index 26c481d2998c..d38564fe22df 100644 --- a/drivers/iio/light/hid-sensor-prox.c +++ b/drivers/iio/light/hid-sensor-prox.c @@ -153,14 +153,6 @@ static const struct iio_info prox_info = { .write_raw = &prox_write_raw, }; -/* Function to push data to buffer */ -static void hid_sensor_push_data(struct iio_dev *indio_dev, const void *data, - int len) -{ - dev_dbg(&indio_dev->dev, "hid_sensor_push_data\n"); - iio_push_to_buffers(indio_dev, data); -} - /* Callback handler to send event after all samples are received and captured */ static int prox_proc_event(struct hid_sensor_hub_device *hsdev, unsigned usage_id, @@ -170,10 +162,10 @@ static int prox_proc_event(struct hid_sensor_hub_device *hsdev, struct prox_state *prox_state = iio_priv(indio_dev); dev_dbg(&indio_dev->dev, "prox_proc_event\n"); - if (atomic_read(&prox_state->common_attributes.data_ready)) - hid_sensor_push_data(indio_dev, - &prox_state->human_presence, - sizeof(prox_state->human_presence)); + if (atomic_read(&prox_state->common_attributes.data_ready)) { + dev_dbg(&indio_dev->dev, "hid_sensor_push_data\n"); + iio_push_to_buffers(indio_dev, &prox_state->human_presence); + } return 0; }