| Message ID | 20241118090208.14586-1-hanchunchao@inspur.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: ti-ads1298: Add NULL check in ads1298_init | expand |
> devm_kasprintf() can return a NULL pointer on failure,but this > returned value in ads1298_init() is not checked. > Add NULL check in ads1298_init(), to handle kernel NULL > pointer dereference error. Another wording suggestion: A devm_kasprintf() call can return a null pointer on failure. But such a return value was not checked in this function implementation. Thus add a corresponding check so that a null pointer dereference will be avoided. Regards, Markus
diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 36d43495f603..03f762415fa5 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -613,6 +613,8 @@ static int ads1298_init(struct iio_dev *indio_dev) } indio_dev->name = devm_kasprintf(dev, GFP_KERNEL, "ads129%u%s", indio_dev->num_channels, suffix); + if (!indio_dev->name) + return -ENOMEM; /* Enable internal test signal, double amplitude, double frequency */ ret = regmap_write(priv->regmap, ADS1298_REG_CONFIG2,
devm_kasprintf() can return a NULL pointer on failure,but this returned value in ads1298_init() is not checked. Add NULL check in ads1298_init(), to handle kernel NULL pointer dereference error. Fixes: 00ef7708fa60 ("iio: adc: ti-ads1298: Add driver") Signed-off-by: Charles Han <hanchunchao@inspur.com> --- drivers/iio/adc/ti-ads1298.c | 2 ++ 1 file changed, 2 insertions(+)