| Message ID | 20241203205241.48077-7-l.rubusch@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: accel: adxl345: add FIFO operating with IRQ triggered watermark events | expand |
On Tue, 03 Dec 2024 20:52:37 +0000, Lothar Rubusch wrote: > Add interrupt-names INT1 and INT2 for the two interrupt lines of the > sensor. Only one line will be connected for incoming events. The driver > needs to be configured accordingly. If no interrupt line is set up, the > sensor will still measure, but no events are possible. > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> > --- > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: ignoring, error in schema: properties: maxItems /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:minItems: 1 is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:maxItems: 2 is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:interrupt-names: 'Data ready is only available on INT1, but events can use either or both pins. If not specified, first element assumed to correspond to INT1 and second (where present) to INT2.' is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties: 'minItems' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties: 'maxItems' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties: 'items' should not be valid under {'$ref': '#/definitions/json-schema-prop-names'} hint: A json-schema keyword was found instead of a DT property name. from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:minItems: 1 is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:maxItems: 2 is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml: properties:interrupt-names: 'Data ready is only available on INT1, but events can use either or both pins. If not specified, first element assumed to correspond to INT1 and second (where present) to INT2.' is not of type 'object', 'boolean' from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# Documentation/devicetree/bindings/iio/accel/adi,adxl345.example.dtb: /example-0/i2c/accelerometer@2a: failed to match any schema with compatible: ['adi,adxl345'] Documentation/devicetree/bindings/iio/accel/adi,adxl345.example.dtb: /example-1/spi/accelerometer@0: failed to match any schema with compatible: ['adi,adxl345'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241203205241.48077-7-l.rubusch@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Dec 03, 2024 at 08:52:37PM +0000, Lothar Rubusch wrote: > Add interrupt-names INT1 and INT2 for the two interrupt lines of the > sensor. Only one line will be connected for incoming events. The driver > needs to be configured accordingly. If no interrupt line is set up, the > sensor will still measure, but no events are possible. > > Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> > --- > .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > index 280ed479ef5..c3483a4b652 100644 > --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml > @@ -37,6 +37,17 @@ properties: > interrupts: > maxItems: 1 > > + interrupt-names: > + Data ready is only available on INT1, but events can use either or > + both pins. If not specified, first element assumed to correspond > + to INT1 and second (where present) to INT2. > + minItems: 1 > + maxItems: 2 This does not match your interrupts property. > + items: > + enum: > + - INT1 > + - INT2 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml index 280ed479ef5..c3483a4b652 100644 --- a/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml +++ b/Documentation/devicetree/bindings/iio/accel/adi,adxl345.yaml @@ -37,6 +37,17 @@ properties: interrupts: maxItems: 1 + interrupt-names: + Data ready is only available on INT1, but events can use either or + both pins. If not specified, first element assumed to correspond + to INT1 and second (where present) to INT2. + minItems: 1 + maxItems: 2 + items: + enum: + - INT1 + - INT2 + required: - compatible - reg @@ -61,6 +72,7 @@ examples: reg = <0x2a>; interrupt-parent = <&gpio0>; interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "INT1"; }; }; - | @@ -79,5 +91,6 @@ examples: spi-cpha; interrupt-parent = <&gpio0>; interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "INT2"; }; };
Add interrupt-names INT1 and INT2 for the two interrupt lines of the sensor. Only one line will be connected for incoming events. The driver needs to be configured accordingly. If no interrupt line is set up, the sensor will still measure, but no events are possible. Signed-off-by: Lothar Rubusch <l.rubusch@gmail.com> --- .../devicetree/bindings/iio/accel/adi,adxl345.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)