diff mbox series

[v2] iio: adc: ti-ads124s08: Switch to fsleep()

Message ID 20241209181624.1260868-1-festevam@gmail.com (mailing list archive)
State New
Headers show
Series [v2] iio: adc: ti-ads124s08: Switch to fsleep() | expand

Commit Message

Fabio Estevam Dec. 9, 2024, 6:16 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

According to Documentation/timers/delay_sleep_functions.rst,
fsleep() is the preferred delay function to be used in non-atomic
context, so switch to it accordingly.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Use andriy.shevchenko@linux.intel.com in the Suggested-by tag.
- Add Reviewed-by.

 drivers/iio/adc/ti-ads124s08.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron Dec. 15, 2024, 12:30 p.m. UTC | #1 
On Mon,  9 Dec 2024 15:16:24 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <festevam@denx.de>
> 
> According to Documentation/timers/delay_sleep_functions.rst,
> fsleep() is the preferred delay function to be used in non-atomic
> context, so switch to it accordingly.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
This is one is stalled behind the cansleep patch which I decided
was trivial enough and sort of a fix so sent the fast way.

If the two had been together I'd have included this as well, but now
it's just an optimization so needs to go the slow route.

Jonathan

> ---
> Changes since v1:
> - Use andriy.shevchenko@linux.intel.com in the Suggested-by tag.
> - Add Reviewed-by.
> 
>  drivers/iio/adc/ti-ads124s08.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
> index f452f57f11c9..77c299bb4ebc 100644
> --- a/drivers/iio/adc/ti-ads124s08.c
> +++ b/drivers/iio/adc/ti-ads124s08.c
> @@ -184,7 +184,7 @@ static int ads124s_reset(struct iio_dev *indio_dev)
>  
>  	if (priv->reset_gpio) {
>  		gpiod_set_value_cansleep(priv->reset_gpio, 0);
> -		udelay(200);
> +		fsleep(200);
>  		gpiod_set_value_cansleep(priv->reset_gpio, 1);
>  	} else {
>  		return ads124s_write_cmd(indio_dev, ADS124S08_CMD_RESET);
Fabio Estevam Dec. 15, 2024, 12:32 p.m. UTC | #2 
Hi Jonathan,

On Sun, Dec 15, 2024 at 9:30 AM Jonathan Cameron <jic23@kernel.org> wrote:

> If the two had been together I'd have included this as well, but now
> it's just an optimization so needs to go the slow route.

That's OK. This one is just an improvement and can wait.

Thanks
diff mbox series

Patch

diff --git a/drivers/iio/adc/ti-ads124s08.c b/drivers/iio/adc/ti-ads124s08.c
index f452f57f11c9..77c299bb4ebc 100644
--- a/drivers/iio/adc/ti-ads124s08.c
+++ b/drivers/iio/adc/ti-ads124s08.c
@@ -184,7 +184,7 @@  static int ads124s_reset(struct iio_dev *indio_dev)
 
 	if (priv->reset_gpio) {
 		gpiod_set_value_cansleep(priv->reset_gpio, 0);
-		udelay(200);
+		fsleep(200);
 		gpiod_set_value_cansleep(priv->reset_gpio, 1);
 	} else {
 		return ads124s_write_cmd(indio_dev, ADS124S08_CMD_RESET);