diff mbox series

[02/20] io: adc: ina2xx-adc: Fix sign and use aligned_s64 for timestamp.

Message ID 20241215182912.481706-3-jic23@kernel.org (mailing list archive)
State Accepted
Headers show
Series IIO: Tidying up timestamp alignment markings. | expand

Commit Message

Jonathan Cameron Dec. 15, 2024, 6:28 p.m. UTC
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Whilst it doesn't actually make any difference because the code
that fills this field doesn't care, timestamps are all signed.
Use the new aligned_s64 instead of open coding alignment to avoid
confusing static analyzers and give slightly cleaner code.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
 drivers/iio/adc/ina2xx-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Uwe Kleine-König Jan. 30, 2025, 3:40 p.m. UTC | #1
Hello,

this patch is in next as 1b54068b5934a871f1895adc5e5ca4355781eeb7.

Maybe it's already to late for that, but if not:

	$Subject ~= s/io:/iio:/

Best regards
Uwe
Jonathan Cameron Jan. 30, 2025, 4:10 p.m. UTC | #2
On Thu, 30 Jan 2025 16:40:04 +0100
Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote:

> Hello,
> 
> this patch is in next as 1b54068b5934a871f1895adc5e5ca4355781eeb7.
> 
> Maybe it's already to late for that, but if not:
> 
> 	$Subject ~= s/io:/iio:/
> 
> Best regards
> Uwe
> 

Long gone :( It's in mainline.

Jonathan
diff mbox series

Patch

diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index 48c95e12e791..40d14faa71c5 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -150,7 +150,7 @@  struct ina2xx_chip_info {
 	/* data buffer needs space for channel data and timestamp */
 	struct {
 		u16 chan[4];
-		u64 ts __aligned(8);
+		aligned_s64 ts;
 	} scan;
 };