| Message ID | 20241216-apds9160-driver-v3-1-c29f6c670bdb@dimonoff.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for Avago/Broadcom APDS9160 | expand |
On Mon, Dec 16, 2024 at 05:55:40PM -0500, Mikael Gonella-Bolduc via B4 Relay wrote: > From: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> > > Add device tree bindings for APDS9160 > Note: Using alternate email for maintainer > > Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
On Tue, 17 Dec 2024 18:31:09 +0000 Conor Dooley <conor@kernel.org> wrote: > On Mon, Dec 16, 2024 at 05:55:40PM -0500, Mikael Gonella-Bolduc via B4 Relay wrote: > > From: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> > > > > Add device tree bindings for APDS9160 > > Note: Using alternate email for maintainer > > > > Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Conor, any idea how we got that title on a reply to a completely different series? Anyhow, I'll assume you intended to give RB to Mikael's patch! Jonathan
On Thu, Dec 19, 2024 at 03:32:49PM +0000, Jonathan Cameron wrote: > On Tue, 17 Dec 2024 18:31:09 +0000 > Conor Dooley <conor@kernel.org> wrote: > > > On Mon, Dec 16, 2024 at 05:55:40PM -0500, Mikael Gonella-Bolduc via B4 Relay wrote: > > > From: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> > > > > > > Add device tree bindings for APDS9160 > > > Note: Using alternate email for maintainer > > > > > > Signed-off-by: Mikael Gonella-Bolduc <mgonellabolduc@dimonoff.com> > > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Conor, any idea how we got that title on a reply to a completely different series? mutt bug? I actually noticed that the subject line was not correct when I sent the mail, but I thought it was a visual bug in mutt rather than one that affected the mail itself. mutt sometimes lags pretty badly for me, there's a good chance I queued up the actions required to delete the $subject thread, jump to this patch and initiate the reply-all process during one of these periods of lag? I'm not entirely sure of that, but I do know for sure that I saw the erroneous subject in mutt's "mail configuration" screen after I had hit y to send it. > Anyhow, I'll assume you intended to give RB to Mikael's patch! Ye, content of the mail is what's correct here.
diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml new file mode 100644 index 0000000000000000000000000000000000000000..525fba52f156df3b78e24d7d0d445fe9d882eaa7 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9160.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/brcm,apds9160.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom Combined Proximity & Ambient light sensor + +maintainers: + - Mikael Gonella-Bolduc <m.gonella.bolduc@gmail.com> + +description: | + Datasheet: https://docs.broadcom.com/docs/APDS-9160-003-DS + +properties: + compatible: + enum: + - brcm,apds9160 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vdd-supply: true + +required: + - compatible + - reg + - vdd-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@53 { + compatible = "brcm,apds9160"; + reg = <0x53>; + vdd-supply = <&vdd_reg>; + interrupts = <29 IRQ_TYPE_EDGE_FALLING>; + interrupt-parent = <&pinctrl>; + }; + }; +...