| Message ID | 20241218114809.1378063-2-u.kleine-koenig@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: ad_sigma_delta: Use `unsigned int` instead of plain `unsigned` | expand |
On Wed, 18 Dec 2024 12:48:09 +0100 Uwe Kleine-König <u.kleine-koenig@baylibre.com> wrote: > This fixes a checkpatch warning: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > #70: FILE: drivers/iio/adc/ad_sigma_delta.c:253: > + unsigned status_reg; > > Fixes: 132d44dc6966 ("iio: adc: ad_sigma_delta: Check for previous ready signals") > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Applied. I dropped the fixes tag (which was useful to me to find the patch) because it's just a warning + I don't want to mess up if I do have to rebase for some reasons (and all the tags change!) Thanks, Jonathan > --- > Hello, > > if it's not already to late for that, feel free to squash this into the > original commit. > > Best regards > Uwe > > drivers/iio/adc/ad_sigma_delta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c > index c3c81aef34d8..7164ae255ed7 100644 > --- a/drivers/iio/adc/ad_sigma_delta.c > +++ b/drivers/iio/adc/ad_sigma_delta.c > @@ -251,7 +251,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta > if (sigma_delta->rdy_gpiod) { > pending_event = gpiod_get_value(sigma_delta->rdy_gpiod); > } else { > - unsigned status_reg; > + unsigned int status_reg; > > ret = ad_sd_read_reg(sigma_delta, AD_SD_REG_STATUS, 1, &status_reg); > if (ret) > > base-commit: 132d44dc6966c1cf841ffe0f6f048165687e870b
diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c index c3c81aef34d8..7164ae255ed7 100644 --- a/drivers/iio/adc/ad_sigma_delta.c +++ b/drivers/iio/adc/ad_sigma_delta.c @@ -251,7 +251,7 @@ static int ad_sigma_delta_clear_pending_event(struct ad_sigma_delta *sigma_delta if (sigma_delta->rdy_gpiod) { pending_event = gpiod_get_value(sigma_delta->rdy_gpiod); } else { - unsigned status_reg; + unsigned int status_reg; ret = ad_sd_read_reg(sigma_delta, AD_SD_REG_STATUS, 1, &status_reg); if (ret)
This fixes a checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #70: FILE: drivers/iio/adc/ad_sigma_delta.c:253: + unsigned status_reg; Fixes: 132d44dc6966 ("iio: adc: ad_sigma_delta: Check for previous ready signals") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> --- Hello, if it's not already to late for that, feel free to squash this into the original commit. Best regards Uwe drivers/iio/adc/ad_sigma_delta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 132d44dc6966c1cf841ffe0f6f048165687e870b