Message ID | 20241219234745.58723-3-vassilisamir@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Headers | show |
Series | dt-bindings: iio: imu: add missing property type | expand |
On Fri, Dec 20, 2024 at 12:47:44AM +0100, Vasileios Amoiridis wrote: > Add missing type description "boolean" for the drive-open-drain property. > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > index 7b0cde1c9b0a..860a6c1fea3c 100644 > --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > @@ -41,6 +41,7 @@ properties: > - INT2 > > drive-open-drain: > + type: boolean > description: > set if the specified interrupt pins should be configured as > open drain. If not set, defaults to push-pull. Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com>
On Mon, Dec 23, 2024 at 02:50:53PM -0500, Alex Lanzano wrote: > On Fri, Dec 20, 2024 at 12:47:44AM +0100, Vasileios Amoiridis wrote: > > Add missing type description "boolean" for the drive-open-drain property. > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > --- > > Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > index 7b0cde1c9b0a..860a6c1fea3c 100644 > > --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > @@ -41,6 +41,7 @@ properties: > > - INT2 > > > > drive-open-drain: > > + type: boolean > > description: > > set if the specified interrupt pins should be configured as > > open drain. If not set, defaults to push-pull. > > Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> What do you mean with this tag? A sign-off means you're part of the chain of custody of the patch, but you're neither author nor submitter. Did you mean Reviewed-by or Acked-by?
On Wed, Dec 25, 2024 at 02:21:42PM +0000, Conor Dooley wrote: > On Mon, Dec 23, 2024 at 02:50:53PM -0500, Alex Lanzano wrote: > > On Fri, Dec 20, 2024 at 12:47:44AM +0100, Vasileios Amoiridis wrote: > > > Add missing type description "boolean" for the drive-open-drain property. > > > > > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > > --- > > > Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > > index 7b0cde1c9b0a..860a6c1fea3c 100644 > > > --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > > > @@ -41,6 +41,7 @@ properties: > > > - INT2 > > > > > > drive-open-drain: > > > + type: boolean > > > description: > > > set if the specified interrupt pins should be configured as > > > open drain. If not set, defaults to push-pull. > > > > Signed-off-by: Alex Lanzano <lanzano.alex@gmail.com> > > What do you mean with this tag? A sign-off means you're part of the > chain of custody of the patch, but you're neither author nor submitter. > Did you mean Reviewed-by or Acked-by? Whoops! I ment to use the reviewed-by tag
On Fri, Dec 20, 2024 at 12:47:44AM +0100, Vasileios Amoiridis wrote: > Add missing type description "boolean" for the drive-open-drain property. > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > index 7b0cde1c9b0a..860a6c1fea3c 100644 > --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml > @@ -41,6 +41,7 @@ properties: > - INT2 > > drive-open-drain: > + type: boolean > description: > set if the specified interrupt pins should be configured as > open drain. If not set, defaults to push-pull. > -- > 2.43.0 > Ignore previous tag I sent in. Reviewed-by: Alex Lanzano <lanzano.alex@gmail.com>
diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml index 7b0cde1c9b0a..860a6c1fea3c 100644 --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml @@ -41,6 +41,7 @@ properties: - INT2 drive-open-drain: + type: boolean description: set if the specified interrupt pins should be configured as open drain. If not set, defaults to push-pull.
Add missing type description "boolean" for the drive-open-drain property. Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 1 + 1 file changed, 1 insertion(+)