| Message ID | 20250124113741.36275-1-markus.burri@mt.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | iio: adc: ad7192: fix channel select | expand |
On Fri, 2025-01-24 at 12:37 +0100, Markus Burri wrote: > Channel configuration doesn't work as expected. > For FIELD_PREP the bit mask is needed and not the bit number. > > Signed-off-by: Markus Burri <markus.burri@mt.com> > --- LGTM. Just missing a fixes tag. With that: Reviewed-by: Nuno Sá <nuno.sa@analog.com> > drivers/iio/adc/ad7192.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c > index 1c87db0e0460..c4effe8429c8 100644 > --- a/drivers/iio/adc/ad7192.c > +++ b/drivers/iio/adc/ad7192.c > @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev > *indio_dev, const unsigned lon > > conf &= ~AD7192_CONF_CHAN_MASK; > for_each_set_bit(i, scan_mask, 8) > - conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i); > + conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i)); > > ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf); > if (ret < 0) > > base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c index 1c87db0e0460..c4effe8429c8 100644 --- a/drivers/iio/adc/ad7192.c +++ b/drivers/iio/adc/ad7192.c @@ -1082,7 +1082,7 @@ static int ad7192_update_scan_mode(struct iio_dev *indio_dev, const unsigned lon conf &= ~AD7192_CONF_CHAN_MASK; for_each_set_bit(i, scan_mask, 8) - conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, i); + conf |= FIELD_PREP(AD7192_CONF_CHAN_MASK, BIT(i)); ret = ad_sd_write_reg(&st->sd, AD7192_REG_CONF, 3, conf); if (ret < 0)
Channel configuration doesn't work as expected. For FIELD_PREP the bit mask is needed and not the bit number. Signed-off-by: Markus Burri <markus.burri@mt.com> --- drivers/iio/adc/ad7192.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04