diff mbox series

[v3,05/17] dt-bindings: iio: adc: ad7768-1: document regulator provider property

Message ID 20250211234717.1008325-1-Jonathan.Santos@analog.com (mailing list archive)
State Superseded
Headers show
Series iio: adc: ad7768-1: Add features, improvements, and fixes | expand

Commit Message

Jonathan Santos Feb. 11, 2025, 11:47 p.m. UTC
The AD7768-1 provides a buffered common-mode voltage output
on the VCM pin that can be used to bias analog input signals.

Add regulators property to enable the use of the VCM output,
referenced here as vcm_output, by any other device.

Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
---
v3 Changes:
* VCM is now provided as a regulator within the device, instead of a 
  custom property.

v2 Changes:
* New patch in v2.
---
 .../bindings/iio/adc/adi,ad7768-1.yaml        | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

Comments

Krzysztof Kozlowski Feb. 12, 2025, 7:17 a.m. UTC | #1
On Tue, Feb 11, 2025 at 08:47:16PM -0300, Jonathan Santos wrote:
> The AD7768-1 provides a buffered common-mode voltage output
> on the VCM pin that can be used to bias analog input signals.
> 
> Add regulators property to enable the use of the VCM output,
> referenced here as vcm_output, by any other device.
> 
> Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
> ---
> v3 Changes:
> * VCM is now provided as a regulator within the device, instead of a 
>   custom property.
> 
> v2 Changes:
> * New patch in v2.

There is some mess in this posting. Nothing looks threaded and b4 does
not see entire posting.

Sorry, don't make it complicated to us. Send proper submission - see
numorous guides or submitting-patches - so reviewing will be
straightforward.

Best regards,
Krzysztof
Jonathan Santos Feb. 12, 2025, 3:01 p.m. UTC | #2
On 02/12, Krzysztof Kozlowski wrote:
> On Tue, Feb 11, 2025 at 08:47:16PM -0300, Jonathan Santos wrote:
> > The AD7768-1 provides a buffered common-mode voltage output
> > on the VCM pin that can be used to bias analog input signals.
> > 
> > Add regulators property to enable the use of the VCM output,
> > referenced here as vcm_output, by any other device.
> > 
> > Signed-off-by: Jonathan Santos <Jonathan.Santos@analog.com>
> > ---
> > v3 Changes:
> > * VCM is now provided as a regulator within the device, instead of a 
> >   custom property.
> > 
> > v2 Changes:
> > * New patch in v2.
> 
> There is some mess in this posting. Nothing looks threaded and b4 does
> not see entire posting.
> 
> Sorry, don't make it complicated to us. Send proper submission - see
> numorous guides or submitting-patches - so reviewing will be
> straightforward.
> 
> Best regards,
> Krzysztof

I am sorry about that, my mistake. I missed the --thread option
when creating the patches. I will resend them properly. 

Apologies,
Jonathan S.

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
index e2f9782b5fc8..38f7bb0a0e20 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
@@ -59,6 +59,19 @@  properties:
       in any way, for example if the filter decimation rate changes.
       As the line is active low, it should be marked GPIO_ACTIVE_LOW.
 
+  regulators:
+    type: object
+    description:
+      list of regulators provided by this controller.
+
+    properties:
+      vcm_output:
+        $ref: /schemas/regulator/regulator.yaml#
+        type: object
+        unevaluatedProperties: false
+
+    additionalProperties: false
+
   reset-gpios:
     maxItems: 1
 
@@ -152,6 +165,14 @@  examples:
                 reg = <0>;
                 label = "channel_0";
             };
+
+            regulators {
+              vcm_reg: vcm_output {
+                regulator-name = "vcm_output";
+                regulator-min-microvolt = <900000>;
+                regulator-max-microvolt = <2500000>;
+              };
+            };
         };
     };
 ...